From: David Miller <davem@davemloft.net>
To: chianglungyu@gmail.com
Cc: ast@plumgrid.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: filter: fix possible memory leak in __sk_prepare_filter()
Date: Mon, 02 Jun 2014 17:50:09 -0700 (PDT) [thread overview]
Message-ID: <20140602.175009.223327851419748409.davem@davemloft.net> (raw)
In-Reply-To: <1401601045-7829-1-git-send-email-chianglungyu@gmail.com>
From: Leon Yu <chianglungyu@gmail.com>
Date: Sun, 1 Jun 2014 05:37:25 +0000
> __sk_prepare_filter() was reworked in commit bd4cf0ed3 (net: filter:
> rework/optimize internal BPF interpreter's instruction set) so that it should
> have uncharged memory once things went wrong. However that work isn't complete.
> Error is handled only in __sk_migrate_filter() while memory can still leak in
> the error path right after sk_chk_filter().
>
> Signed-off-by: Leon Yu <chianglungyu@gmail.com>
Applied, thanks.
prev parent reply other threads:[~2014-06-03 0:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-01 5:37 Leon Yu
2014-06-01 6:25 ` Alexei Starovoitov
2014-06-03 0:50 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140602.175009.223327851419748409.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ast@plumgrid.com \
--cc=chianglungyu@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®