From: Mark Brown <broonie@kernel.org>
To: Chew Chiau Ee <chiau.ee.chew@intel.com>
Cc: Eric Miao <eric.y.miao@gmail.com>,
Russell King <linux@arm.linux.org.uk>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
Grant Likely <grant.likely@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Darren Hart <dvhart@linux.intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
LKML <linux-kernel@vger.kernel.org>,
linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] spi/pxa2xx-pci: Add common clock framework support in PCI glue layer
Date: Mon, 2 Jun 2014 13:46:38 +0100 [thread overview]
Message-ID: <20140602124638.GD31751@sirena.org.uk> (raw)
In-Reply-To: <1401738379-4107-2-git-send-email-chiau.ee.chew@intel.com>
[-- Attachment #1: Type: text/plain, Size: 632 bytes --]
On Tue, Jun 03, 2014 at 03:46:18AM +0800, Chew Chiau Ee wrote:
> ---
> drivers/spi/spi-pxa2xx-pci.c | 20 ++++++++++++++++++++
> 1 files changed, 20 insertions(+), 0 deletions(-)
> + clk = clk_register_fixed_rate(&dev->dev, "spi_pxa2xx_clk", NULL,
> + CLK_IS_ROOT, c->max_clk_rate);
> + if (IS_ERR(clk))
> + return PTR_ERR(clk);
This is pretty much fine code wise but I'd expect to see some Kconfig
updates adding dependencies on the clock API - clk_register_fixed_rate()
is only provided if the fixed rate driver is present. I'm also not
seeing any changes to unregister the fixed rate clock as the device is
removed.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-06-02 12:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-02 19:46 [PATCH 0/2] Add common clk framework support for PCI mode SPI PXA2XX Chew Chiau Ee
2014-06-02 19:46 ` [PATCH 1/2] spi/pxa2xx-pci: Add common clock framework support in PCI glue layer Chew Chiau Ee
2014-06-02 12:46 ` Mark Brown [this message]
2014-06-02 19:46 ` [PATCH 2/2] clkdev: Export clk_register_clkdev Chew Chiau Ee
2014-06-02 12:35 ` Mark Brown
2014-06-02 15:16 ` Darren Hart
2014-06-02 12:36 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140602124638.GD31751@sirena.org.uk \
--to=broonie@kernel.org \
--cc=chiau.ee.chew@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dvhart@linux.intel.com \
--cc=eric.y.miao@gmail.com \
--cc=grant.likely@linaro.org \
--cc=haojian.zhuang@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mika.westerberg@linux.intel.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome