From: Mark Brown <broonie@kernel.org>
To: Tim Kryger <tim.kryger@gmail.com>
Cc: Jingoo Han <jg1.han@samsung.com>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org, Matt Porter <mporter@linaro.org>,
Tim Kryger <tim.kryger@linaro.org>
Subject: Re: [PATCH 1/3] regulator: bcm590xx: remove unnecessary OOM messages
Date: Mon, 2 Jun 2014 13:50:55 +0100 [thread overview]
Message-ID: <20140602125055.GE31751@sirena.org.uk> (raw)
In-Reply-To: <CAD7vxxKT+Wq2ArH9iYLm2OUeBSqKvzORKZ1NnoyPcdcDH6wOKw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 473 bytes --]
On Mon, Jun 02, 2014 at 12:12:20AM -0700, Tim Kryger wrote:
> The probe method of this driver, on the other hand, performs several
> allocations and the error messages you intend to remove conveniently
> pinpoint which one failed. While the offsets in the trace could be
> used to derive the same information, I am skeptical that is enough to
> justify removing the messages.
On the other hand how likely is anyone to care which particular
allocation triggered the OOM?
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-06-02 12:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-02 6:27 Jingoo Han
2014-06-02 6:29 ` [PATCH 2/3] regulator: max8649: " Jingoo Han
2014-06-02 14:12 ` Mark Brown
2014-06-02 6:30 ` [PATCH 3/3] regulator: pbias: " Jingoo Han
2014-06-02 14:15 ` Mark Brown
2014-06-02 7:12 ` [PATCH 1/3] regulator: bcm590xx: " Tim Kryger
2014-06-02 12:50 ` Mark Brown [this message]
2014-06-03 6:41 ` Tim Kryger
2014-06-03 10:05 ` Mark Brown
2014-06-03 15:19 ` 'Matt Porter'
2014-06-06 10:08 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140602125055.GE31751@sirena.org.uk \
--to=broonie@kernel.org \
--cc=jg1.han@samsung.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mporter@linaro.org \
--cc=tim.kryger@gmail.com \
--cc=tim.kryger@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®