From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755467AbaFBOyp (ORCPT <rfc822;w@1wt.eu>);
	Mon, 2 Jun 2014 10:54:45 -0400
Received: from lxorguk.ukuu.org.uk ([81.2.110.251]:49491 "EHLO
	lxorguk.ukuu.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754693AbaFBOyo (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 2 Jun 2014 10:54:44 -0400
Date: Mon, 2 Jun 2014 15:53:40 +0100
From: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
To: Fabian Frederick <fabf@skynet.be>
Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
        Anil Gurumurthy <anil.gurumurthy@qlogic.com>,
        "James E.J. Bottomley" <JBottomley@parallels.com>
Subject: Re: [RFC 1/1] drivers/scsi/bfa/bfad_debugfs.c: replace 2
 kzalloc/copy_from_user to memdup_user
Message-ID: <20140602155340.0814cf04@alan.etchedpixels.co.uk>
In-Reply-To: <1401469656-10332-1-git-send-email-fabf@skynet.be>
References: <1401469656-10332-1-git-send-email-fabf@skynet.be>
Organization: Intel Corporation
X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.23; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 30 May 2014 19:07:36 +0200
Fabian Frederick <fabf@skynet.be> wrote:

> (memdup_user can be used to replace kmalloc/copy_from_user. Not sure if it's ok with kzalloc ...)


> +	kern_buf = memdup_user((void __user *)buf, nbytes);

> +	if (IS_ERR(kern_buf)) {
> +		printk(KERN_INFO "bfad[%d]: Failed to copy buffer\n",
> +		       bfad->inst_no);

While you are tidying up lose the printk KERN_INFO stuff here, it really
isn't needed.

Looks good to me and it also fixes the incorrect return of -ENOMEM the
old code had on a copy_from_user failing.

Alan