From: Stephen Hemminger <stephen@networkplumber.org>
To: "K. Y. Srinivasan" <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>
Cc: devel@linuxdriverproject.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: [PATCH net-next] hyper-v: make uuid_le const
Date: Tue, 3 Jun 2014 08:38:15 -0700 [thread overview]
Message-ID: <20140603083815.14688f8a@nehalam.linuxnetplumber.net> (raw)
The uuid structure could be managed as a const in several places.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
Patch against net-next because that is where most recent
hyper-v related changes are.
--- a/drivers/hv/channel_mgmt.c 2014-02-12 08:21:54.627887619 -0800
+++ b/drivers/hv/channel_mgmt.c 2014-06-03 08:08:47.030901345 -0700
@@ -365,7 +365,7 @@ static u32 next_vp;
* performance critical channels (IDE, SCSI and Network) will be uniformly
* distributed across all available CPUs.
*/
-static u32 get_vp_index(uuid_le *type_guid)
+static u32 get_vp_index(const uuid_le *type_guid)
{
u32 cur_cpu;
int i;
--- a/drivers/hv/vmbus_drv.c 2014-04-07 11:21:05.704486433 -0700
+++ b/drivers/hv/vmbus_drv.c 2014-06-03 08:11:14.771854064 -0700
@@ -435,7 +435,7 @@ static int vmbus_uevent(struct device *d
return ret;
}
-static uuid_le null_guid;
+static const uuid_le null_guid;
static inline bool is_null_guid(const __u8 *guid)
{
@@ -450,7 +450,7 @@ static inline bool is_null_guid(const __
*/
static const struct hv_vmbus_device_id *hv_vmbus_get_id(
const struct hv_vmbus_device_id *id,
- __u8 *guid)
+ const __u8 *guid)
{
for (; !is_null_guid(id->guid); id++)
if (!memcmp(&id->guid, guid, sizeof(uuid_le)))
@@ -779,9 +779,9 @@ EXPORT_SYMBOL_GPL(vmbus_driver_unregiste
* vmbus_device_create - Creates and registers a new child device
* on the vmbus.
*/
-struct hv_device *vmbus_device_create(uuid_le *type,
- uuid_le *instance,
- struct vmbus_channel *channel)
+struct hv_device *vmbus_device_create(const uuid_le *type,
+ const uuid_le *instance,
+ struct vmbus_channel *channel)
{
struct hv_device *child_device_obj;
--- a/drivers/hv/hyperv_vmbus.h 2014-04-07 11:21:05.704486433 -0700
+++ b/drivers/hv/hyperv_vmbus.h 2014-06-03 08:27:12.618223800 -0700
@@ -644,9 +644,9 @@ extern struct vmbus_connection vmbus_con
/* General vmbus interface */
-struct hv_device *vmbus_device_create(uuid_le *type,
- uuid_le *instance,
- struct vmbus_channel *channel);
+struct hv_device *vmbus_device_create(const uuid_le *type,
+ const uuid_le *instance,
+ struct vmbus_channel *channel);
int vmbus_device_register(struct hv_device *child_device_obj);
void vmbus_device_unregister(struct hv_device *device_obj);
next reply other threads:[~2014-06-03 15:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-03 15:38 Stephen Hemminger [this message]
2014-06-03 17:30 ` KY Srinivasan
2014-06-04 1:19 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140603083815.14688f8a@nehalam.linuxnetplumber.net \
--to=stephen@networkplumber.org \
--cc=devel@linuxdriverproject.org \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®