From: Jiri Olsa <jolsa@redhat.com>
To: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>,
linux-kernel@vger.kernel.org,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Corey Ashford <cjashfor@linux.vnet.ibm.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@kernel.org>,
Jean Pihet <jean.pihet@linaro.org>,
Namhyung Kim <namhyung@kernel.org>,
Paul Mackerras <paulus@samba.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH 06/13] perf tools: Cache dso data file descriptor
Date: Tue, 3 Jun 2014 15:41:45 +0200 [thread overview]
Message-ID: <20140603134145.GD2864@krava.brq.redhat.com> (raw)
In-Reply-To: <538DCF59.6000808@gmail.com>
On Tue, Jun 03, 2014 at 07:36:25AM -0600, David Ahern wrote:
> On 6/2/14, 3:18 PM, Jiri Olsa wrote:
> >We keep dsos data file descriptors open until their count reaches
> >the half of the current fd open limit (RLIMIT_NOFILE). In this case
> >we close file descriptor of the first opened dso object.
> >
> >We've got overall speedup (24% for my workload) of report:
> > 'perf report --stdio -i perf-test.data' (3 runs)
> > (perf-test.data size was around 12GB)
> >
> > current code:
> > 446,826,474,217 cycles ( +- 0.23% )
> > 669,435,100,846 instructions ( +- 0.03% )
> >
> > 266.380674551 seconds time elapsed ( +- 0.37% )
> >
> > change:
> > 558,345,509,819 cycles ( +- 0.55% )
> > 817,283,647,637 instructions ( +- 0.03% )
> >
> > 351.564209617 seconds time elapsed ( +- 0.89% )
>
> message is confusing. Looks like time went up.
aaargh.. right ;-) it should bethe other way around
thanks,
jirka
next prev parent reply other threads:[~2014-06-03 13:42 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-02 21:18 [PATCHv3 00/13] perf tools: Speedup DWARF unwind Jiri Olsa
2014-06-02 21:18 ` [PATCH 01/13] perf tools: Cache register accesses for unwind processing Jiri Olsa
2014-06-02 21:18 ` [PATCH 02/13] perf tools: Separate dso data related variables Jiri Olsa
2014-06-02 21:18 ` [PATCH 03/13] perf tools: Add data_fd into dso object Jiri Olsa
2014-06-02 21:18 ` [PATCH 04/13] perf tools: Add global list of opened dso objects Jiri Olsa
2014-06-02 21:18 ` [PATCH 05/13] perf tools: Add global count " Jiri Olsa
2014-06-02 21:18 ` [PATCH 06/13] perf tools: Cache dso data file descriptor Jiri Olsa
2014-06-03 13:36 ` David Ahern
2014-06-03 13:41 ` Jiri Olsa [this message]
2014-06-03 13:39 ` David Ahern
2014-06-03 13:44 ` Jiri Olsa
2014-06-02 21:18 ` [PATCH 07/13] perf tools: Add file size check and factor dso__data_read_offset Jiri Olsa
2014-06-02 21:18 ` [PATCH 08/13] perf tools: Allow to close dso fd in case of open failure Jiri Olsa
2014-06-02 21:18 ` [PATCH 09/13] perf tools: Add dso__data_* interface descriptons Jiri Olsa
2014-06-03 13:45 ` David Ahern
2014-06-03 15:32 ` Jiri Olsa
2014-06-02 21:18 ` [PATCH 10/13] perf tests: Spawn child for each test Jiri Olsa
2014-06-03 13:48 ` David Ahern
2014-06-02 21:18 ` [PATCH 11/13] perf tests: Allow reuse of test_file function Jiri Olsa
2014-06-03 13:51 ` David Ahern
2014-06-03 15:35 ` Jiri Olsa
2014-06-03 18:41 ` David Ahern
2014-06-02 21:18 ` [PATCH 12/13] perf tests: Add test for caching dso file descriptors Jiri Olsa
2014-06-03 13:56 ` David Ahern
2014-06-02 21:18 ` [PATCH 13/13] perf tests: Add test for closing dso objects on EMFILE error Jiri Olsa
2014-06-03 13:58 ` David Ahern
2014-06-04 14:36 [PATCHv4 00/13] perf tools: Speedup DWARF unwind Jiri Olsa
2014-06-04 14:36 ` [PATCH 06/13] perf tools: Cache dso data file descriptor Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140603134145.GD2864@krava.brq.redhat.com \
--to=jolsa@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=cjashfor@linux.vnet.ibm.com \
--cc=dsahern@gmail.com \
--cc=fweisbec@gmail.com \
--cc=jean.pihet@linaro.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome