From: Mark Brown <broonie@kernel.org>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regulator: as3722: Make 0 a valid selector
Date: Tue, 3 Jun 2014 16:51:43 +0100 [thread overview]
Message-ID: <20140603155143.GH31751@sirena.org.uk> (raw)
In-Reply-To: <1401808652-20524-1-git-send-email-thierry.reding@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 665 bytes --]
On Tue, Jun 03, 2014 at 05:17:32PM +0200, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> As of commit 064d5cd110f9 (regulator: core: Fix the init of DT defined
> fixed regulators) the regulator core tries to query the current voltage
> of a regulator when applying constraints. This exposes a bug in the
> AS3722 regulator driver which fails to read the voltage of disabled
> regulators. The reason is that the hardware is programmed to a selector
> of 0, but none of the voltage tables include 0 as a valid selector. The
> datasheets indicate that 0 is a valid selector when the regulators are
> powered off.
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2014-06-03 15:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-03 15:17 Thierry Reding
2014-06-03 15:51 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140603155143.GH31751@sirena.org.uk \
--to=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®