From: Peter Zijlstra <peterz@infradead.org>
To: Andy Lutomirski <luto@amacapital.net>
Cc: umgwanakikbuti@gmail.com, mingo@kernel.org, tglx@linutronix.de,
nicolas.pitre@linaro.org, daniel.lezcano@linaro.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/6] sched,idle: Clear polling before descheduling the idle thread
Date: Wed, 4 Jun 2014 09:53:24 +0200 [thread overview]
Message-ID: <20140604075324.GI30445@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <ad9dcf321a5b74e72a1b63a0d59c8ddc68509c0f.1401841482.git.luto@amacapital.net>
[-- Attachment #1: Type: text/plain, Size: 575 bytes --]
On Tue, Jun 03, 2014 at 05:29:50PM -0700, Andy Lutomirski wrote:
> @@ -229,6 +234,8 @@ static void cpu_idle_loop(void)
> */
> preempt_set_need_resched();
> tick_nohz_idle_exit();
> + __current_clr_polling();
> + smp_mb__after_clear_bit();
barriers always need a comment, and I'm not entirely sure why you put
this one here.
Merging the NR set and POLLING tests into a single atomic made the
entire barrier situation somewhat more complicated and I really need to
rethink that.
> schedule_preempt_disabled();
> }
> }
> --
> 1.9.3
>
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-06-04 7:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-04 0:29 [PATCH 0/6] sched: Cleanup and improve polling idle loops Andy Lutomirski
2014-06-04 0:29 ` [PATCH 1/6] cpuidle: Set polling in poll_idle Andy Lutomirski
2014-06-04 0:29 ` [PATCH 2/6] sched,trace: Add a tracepoint for remote wakeups via polling Andy Lutomirski
2014-06-04 13:00 ` Daniel Lezcano
2014-06-04 13:54 ` Peter Zijlstra
2014-06-04 14:43 ` Andy Lutomirski
2014-06-04 0:29 ` [PATCH 3/6] sched,idle: Clarify where TIF_NRFLAG_POLLING is set Andy Lutomirski
2014-06-04 13:03 ` Daniel Lezcano
2014-06-04 14:58 ` Andy Lutomirski
2014-06-04 0:29 ` [PATCH 4/6] sched,idle: Clear polling before descheduling the idle thread Andy Lutomirski
2014-06-04 7:44 ` Peter Zijlstra
2014-06-04 14:57 ` Andy Lutomirski
2014-06-04 16:03 ` Peter Zijlstra
2014-06-04 7:53 ` Peter Zijlstra [this message]
2014-06-04 14:46 ` Andy Lutomirski
2014-06-04 0:29 ` [PATCH 5/6] sched,idle: Simplify wake_up_idle_cpu Andy Lutomirski
2014-06-04 0:29 ` [PATCH 6/6] sched: Optimize ttwu IPI Andy Lutomirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140604075324.GI30445@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=daniel.lezcano@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mingo@kernel.org \
--cc=nicolas.pitre@linaro.org \
--cc=tglx@linutronix.de \
--cc=umgwanakikbuti@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome