From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752136AbaFERAu (ORCPT ); Thu, 5 Jun 2014 13:00:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:30018 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751419AbaFERAs (ORCPT ); Thu, 5 Jun 2014 13:00:48 -0400 Date: Thu, 5 Jun 2014 19:00:11 +0200 From: Jiri Olsa To: Stephane Eranian Cc: LKML , Arnaldo Carvalho de Melo , Namhyung Kim , David Ahern , Peter Zijlstra , "mingo@elte.hu" Subject: [PATCH] perf tools: Fix pipe check regression in attr event callback Message-ID: <20140605170011.GA13372@krava.brq.redhat.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 05, 2014 at 06:06:41PM +0200, Stephane Eranian wrote: > Hi Jiri, > > Somehow, I thought you had written a fix to avoid the problem below. > But when I try with tip.git, the problem is still there. > Could you push your fix ASAP. > > Thanks. > > $ perf record -o - noploop 2 | perf inject -b | perf report -i - > # To display the perf.data header info, please use > --header/--header-only options. > # > noploop for 2 seconds > 0x1bd0 [0x28]: failed to process type: 9 hum, I remember fixing another issue.. this one is separated one, please try attached patch. thanks, jirka --- The file factoring in builtin-inject.c object introduced regression in attr event callback. The commit is: 3406912 perf inject: Handle output file via perf_data_file object Following hunk reversed the logic: - if (!inject->pipe_output) + if (&inject->output.is_pipe) putting it back, following example now works: $ perf record -o - kill | perf inject -b | perf report -i - Reported-by: Stephane Eranian Cc: Arnaldo Carvalho de Melo Cc: Corey Ashford Cc: David Ahern Cc: Frederic Weisbecker Cc: Ingo Molnar Cc: Namhyung Kim Cc: Paul Mackerras Cc: Peter Zijlstra Signed-off-by: Jiri Olsa --- tools/perf/builtin-inject.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/builtin-inject.c b/tools/perf/builtin-inject.c index 6a3af00..664010b 100644 --- a/tools/perf/builtin-inject.c +++ b/tools/perf/builtin-inject.c @@ -72,7 +72,7 @@ static int perf_event__repipe_attr(struct perf_tool *tool, if (ret) return ret; - if (&inject->output.is_pipe) + if (!&inject->output.is_pipe) return 0; return perf_event__repipe_synth(tool, event); -- 1.8.3.1