From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751871AbaFFOHi (ORCPT <rfc822;w@1wt.eu>);
	Fri, 6 Jun 2014 10:07:38 -0400
Received: from bombadil.infradead.org ([198.137.202.9]:35067 "EHLO
	bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751174AbaFFOHh (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 6 Jun 2014 10:07:37 -0400
Date: Fri, 6 Jun 2014 16:07:32 +0200
From: Peter Zijlstra <peterz@infradead.org>
To: Trond Myklebust <trond.myklebust@primarydata.com>
Cc: linux-kernel@vger.kernel.org, John Stultz <john.stultz@linaro.org>,
        Ingo Molnar <mingo@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH] Revert lockdep check in raw_seqcount_begin
Message-ID: <20140606140732.GA11371@laptop.programming.kicks-ass.net>
References: <1401982261-11246-1-git-send-email-trond.myklebust@primarydata.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1401982261-11246-1-git-send-email-trond.myklebust@primarydata.com>
User-Agent: Mutt/1.5.21 (2012-12-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jun 05, 2014 at 11:31:01AM -0400, Trond Myklebust wrote:
> This commit reverts the addition of lockdep checking to raw_seqcount_begin
> for the following reasons:
> 
> 1) It violates the naming convention that raw_* functions should not
>    do lockdep checks (a convention that is also followed by the other
>    raw_*_seqcount_begin functions).
> 2) raw_seqcount_begin does not spin, so it can only be part of an ABBA
>    deadlock in very special circumstances (for instance if a lock
>    is held across the entire raw_seqcount_begin()+read_seqcount_retry()
>    loop while also being taken inside the write_seqcount protected area).
> 3) It is causing false positives with some existing callers, and there
>    is no non-lockdep alternative for those callers to use.
> 
> None of the three existing callers (__d_lookup_rcu, netdev_get_name, and
> the NFS state code) appear to use the function in a manner that is ABBA
> deadlock prone.
> 
> Fixes: 1ca7d67cf5d5: seqcount: Add lockdep functionality to seqcount/seqlock
> Cc: John Stultz <john.stultz@linaro.org>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Ingo Molnar <mingo@kernel.org>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Al Viro <viro@zeniv.linux.org.uk>
> Link: http://lkml.kernel.org/r/CAHQdGtRR6SvEhXiqWo24hoUh9AU9cL82Z8Z-d8-7u951F_d+5g@mail.gmail.com
> Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>

Thanks Trond!