From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Scot Doyle <lkml14@scotdoyle.com>
Cc: Benson Leung <bleung@chromium.org>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Olof Johansson <olof@lixom.net>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] platform/chrome: Probe multiple i2c adapters of the same name
Date: Mon, 9 Jun 2014 15:47:00 +0300 [thread overview]
Message-ID: <20140609124700.GJ1657@lahna.fi.intel.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1406062316230.32568@scotdoyle.com>
On Fri, Jun 06, 2014 at 11:25:14PM +0100, Scot Doyle wrote:
> The chromeos_laptop module probes the first i2c adapter with a specific name
> for expected hardware. However, the Acer C720 Chromebook has two i2c
> adapters with the same name. This patch probes each i2c adapter with a
> specific name in turn, until locating the expected hardware.
>
> Signed-off-by: Scot Doyle <lkml14@scotdoyle.com>
> CC: Benson Leung <bleung@chromium.org>
> CC: Mika Westerberg <mika.westerberg@linux.intel.com>
I don't have anything against this approach.
One comment though, if you happen to have two devices with the same
address but in different buses this can go wrong. Not sure how likely
that will happen.
next prev parent reply other threads:[~2014-06-09 12:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-03 13:02 [PATCH] platform/chrome: Add support for Acer C720 Mika Westerberg
2014-06-03 19:46 ` Benson Leung
2014-06-04 8:37 ` Mika Westerberg
2014-06-04 20:12 ` Benson Leung
2014-06-06 22:06 ` [PATCH 0/1] platform/chrome: Probe multiple i2c adapters of the same name Scot Doyle
2014-06-06 22:25 ` [PATCH 1/1] " Scot Doyle
2014-06-09 12:47 ` Mika Westerberg [this message]
2014-06-10 5:08 ` Scot Doyle
2014-06-10 5:17 ` [PATCH v2 " Scot Doyle
2014-06-11 9:24 ` Mika Westerberg
2014-06-11 17:51 ` [PATCH v3 " Scot Doyle
2014-06-11 17:09 ` Benson Leung
2014-06-11 22:23 ` Scot Doyle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140609124700.GJ1657@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=bleung@chromium.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkml14@scotdoyle.com \
--cc=olof@lixom.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome