From: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
To: Peter Hurley <peter@hurleysoftware.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
Valerio Vanni <valerio.vanni@inwind.it>
Subject: Re: [PATCH 1/2] serial: core: Don't drop DTR if system console
Date: Mon, 9 Jun 2014 14:08:23 +0100 [thread overview]
Message-ID: <20140609140823.6013838d@alan.etchedpixels.co.uk> (raw)
In-Reply-To: <1401891371-4946-1-git-send-email-peter@hurleysoftware.com>
On Wed, 4 Jun 2014 10:16:10 -0400
Peter Hurley <peter@hurleysoftware.com> wrote:
> If a tty is opened on a serial console, don't drop DTR on
> last tty close, on tty hangup, or when resetting port hardware
> via TIOCSSERIAL and TIOCSERCONFIG ioctls.
>
> Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
NAK
This introduces a security flaw.
If you have a system with a remote console you dial into then with this
patch applied a modem drop eg from a bad line will no longer drop any
live session and ensure a login is required as it was before.
That's a pretty bad regression case.
If you are running a serial console and want to leave DTR high either
wire the cable that way or don't set HUPCL in the first place. The
technology for fixing this problem already exists!
Alan
next prev parent reply other threads:[~2014-06-09 13:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-30 9:53 serial console does not wake from S3 suspend Valerio Vanni
2014-06-04 14:16 ` [PATCH 1/2] serial: core: Don't drop DTR if system console Peter Hurley
2014-06-04 14:16 ` [PATCH 2/2] serial: core: Preserve termios c_cflag for console resume Peter Hurley
2014-06-04 14:22 ` Greg Kroah-Hartman
2014-06-04 14:46 ` Peter Hurley
2014-06-04 14:48 ` Peter Hurley
2014-06-04 23:31 ` Valerio Vanni
2014-06-04 14:22 ` [PATCH 1/2] serial: core: Don't drop DTR if system console Greg Kroah-Hartman
2014-06-04 14:36 ` Peter Hurley
2014-06-09 13:08 ` One Thousand Gnomes [this message]
2014-06-10 1:20 ` Peter Hurley
2014-06-10 11:01 ` One Thousand Gnomes
2014-06-10 12:30 ` Peter Hurley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140609140823.6013838d@alan.etchedpixels.co.uk \
--to=gnomes@lxorguk.ukuu.org.uk \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=peter@hurleysoftware.com \
--cc=valerio.vanni@inwind.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®