From: Mark Brown <broonie@kernel.org>
To: Marcel Ziswiler <marcel@ziswiler.com>
Cc: Stephen Warren <swarren@wwwdotorg.org>,
thierry.reding@gmail.com, linux@arm.linux.org.uk,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org,
stefan@agner.ch
Subject: Re: [PATCH 2/3] arm: tegra: enable igb, stmpe, i2c chardev, spidev, lm95245, pwm leds
Date: Mon, 9 Jun 2014 23:57:07 +0100 [thread overview]
Message-ID: <20140609225707.GB5099@sirena.org.uk> (raw)
In-Reply-To: <5396322D.6030003@ziswiler.com>
[-- Attachment #1: Type: text/plain, Size: 1742 bytes --]
On Tue, Jun 10, 2014 at 12:16:13AM +0200, Marcel Ziswiler wrote:
> On 06/04/2014 01:17 PM, Mark Brown wrote:
> >You're saying you're controlling it from userspace. This is a
> >particular detail of what you are doing in your system. You happen to
> >want to control the devices you are hanging off the system with
> >userspace drivers but that's just what you're doing right now.
> Sorry, I don't get it. Yes, spidev is to control stuff from user space just
> like i2c-dev however bad that might sound.
There is absolutely nothing wrong with that. What there is a problem
with is putting that implementation detail into a device tree, if
someone comes along and writes an in kernel driver for the same device
the device tree needs to continue to work without modification as it is
an ABI.
> >No, that's in the controller node - the chip selects are described
> >there. The child node references a chip select number that the master
> >has and describes what's connected to that chip select.
> Well, unfortunately SPI without any chip select is just plain simply
> useless. It won't work.
I'm sorry but I'm not seeing how that follows on from what I said?
> >It's a perfectly fine way of controlling things from userspace if that's
> >a sensible way of controlling devices but that does not mean you should
> >describe it in the device tree in that fashion.
> Only that without describing such a chip select in the device tree spidev
> won't ever work.
Again I'm not sure how that follows. To repeat, the chip selects are
described on the SPI controller and referenced by the child devices when
they are instantiated by chip select number. Please refer to the SPI
bindings if this is unclear, or be specific in what is unclear.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-06-09 22:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <c5522b0efcbfc7690dcde6aaf78b9dd568f99604.1401665237.git.marcel@ziswiler.com>
2014-06-01 23:37 ` Marcel Ziswiler
2014-06-02 16:11 ` Stephen Warren
2014-06-02 16:28 ` Marcel Ziswiler
2014-06-02 22:16 ` Mark Brown
2014-06-03 6:02 ` Marcel Ziswiler
2014-06-03 9:45 ` Mark Brown
2014-06-04 6:20 ` Marcel Ziswiler
2014-06-04 11:17 ` Mark Brown
2014-06-09 22:16 ` Marcel Ziswiler
2014-06-09 22:57 ` Mark Brown [this message]
2014-06-01 23:37 ` [PATCH 3/3] arm: tegra: initial support for apalis t30 Marcel Ziswiler
2014-06-02 16:26 ` Stephen Warren
2014-06-02 20:18 ` Marcel Ziswiler
2014-06-02 20:33 ` Stephen Warren
2014-06-02 16:33 ` Stephen Warren
2014-06-02 20:24 ` Marcel Ziswiler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140609225707.GB5099@sirena.org.uk \
--to=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=marcel@ziswiler.com \
--cc=stefan@agner.ch \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®