From: David Miller <davem@davemloft.net>
To: rickard_strandqvist@spectrumdigital.se
Cc: inaky.perez-gonzalez@intel.com, linux-wimax@intel.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: wimax: i2400m: control.c: Cleaning up conjunction always evaluates to false
Date: Wed, 11 Jun 2014 00:15:36 -0700 (PDT) [thread overview]
Message-ID: <20140611.001536.384904520252789239.davem@davemloft.net> (raw)
In-Reply-To: <1402140397-17404-1-git-send-email-rickard_strandqvist@spectrumdigital.se>
From: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Date: Sat, 7 Jun 2014 13:26:37 +0200
> Logical conjunction always evaluates to false: minor < 2 && minor > 1
> I guess what you wanted is rather: minor > 2 || minor < 1
>
> This was partly found using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Applied.
prev parent reply other threads:[~2014-06-11 7:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-07 11:26 Rickard Strandqvist
2014-06-07 11:42 ` Joe Perches
2014-06-07 11:52 ` Rickard Strandqvist
2014-06-11 7:15 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140611.001536.384904520252789239.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=inaky.perez-gonzalez@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wimax@intel.com \
--cc=netdev@vger.kernel.org \
--cc=rickard_strandqvist@spectrumdigital.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®