From: David Miller <davem@davemloft.net>
To: milos.vyletel@gmail.com
Cc: stephen@networkplumber.org, amwang@redhat.com,
netdev@vger.kernel.org, oliver@neukum.org, kuznet@ms2.inr.ac.ru,
jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net,
pshelar@nicira.com, nicolas.dichtel@6wind.com,
mike.rapoport@ravellosystems.com, dborkman@redhat.com,
ogerlitz@mellanox.com, therbert@google.com,
hannes@stressinduktion.org, florent.fourcot@enst-bretagne.fr,
edumazet@google.com, Paul.Durrant@citrix.com,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [patch net-next 3/5] ipv6: consider net.ipv6.conf.all sysctls when making decisions
Date: Wed, 11 Jun 2014 15:32:25 -0700 (PDT) [thread overview]
Message-ID: <20140611.153225.671693159592497903.davem@davemloft.net> (raw)
In-Reply-To: <CAAFXRd1Stuyj2t8Oinr6SQysGbMJKPpY5qe=mO_m0xKR1eSjOQ@mail.gmail.com>
From: Milos Vyletel <milos.vyletel@gmail.com>
Date: Tue, 10 Jun 2014 13:49:35 -0400
> On Tue, Jun 10, 2014 at 1:13 PM, Stephen Hemminger
> <stephen@networkplumber.org> wrote:
>> On Tue, 10 Jun 2014 12:19:11 -0400
>> Milos Vyletel <milos.vyletel@gmail.com> wrote:
>>
>>> As it is right now net.ipv6.conf.all.* are mostly ignored and instead
>>> we're only making decisions based on interface specific settings. These
>>> settings are coppied from net.ipv6.conf.default and changing either all
>>> or default settings have no effect.
>>
>> Although this is the right idea conceptually, it risks creating unhappy
>> users because it changes the semantics of the API. This will probably break
>> somebody's configuration.
>
> You're right but in this case I feel we are moving in the right
> direction. While the
> behavior will change in some cases this change is only adding well known ipv4
> behavior for ipv6 sysctls. In fact documentation briefly mentioned that
> net.ipv6.conf.all.* should change all the interface-specific settings
> but that was
> not the case until now.
You can't just break things on people, no matter how much you think the
current behavior is "poorly designed", "inconsistent with other areas of
the networking", etc. None of those things matter if you have to break
things on people to "fix" it.
I'm not applying this series, sorry.
next prev parent reply other threads:[~2014-06-11 22:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1402417153-2551-1-git-send-email-milos.vyletel@gmail.com>
2014-06-10 16:19 ` [patch net-next 1/5] ipv6: align sysctl table creation code with ipv4 Milos Vyletel
2014-06-10 16:19 ` [patch net-next 2/5] ipv6: rename DEVCONF* to IPV6_DEVCONF* to align " Milos Vyletel
2014-06-10 16:19 ` [patch net-next 3/5] ipv6: consider net.ipv6.conf.all sysctls when making decisions Milos Vyletel
2014-06-10 17:13 ` Stephen Hemminger
2014-06-10 17:49 ` Milos Vyletel
2014-06-11 22:32 ` David Miller [this message]
2014-06-12 15:07 ` Milos Vyletel
2014-06-10 17:15 ` Florent Fourcot
2014-06-10 17:42 ` Milos Vyletel
2014-06-10 16:19 ` [patch net-next 4/5] Documentation: update ipv6 part of networking/ip-sysctl.txt Milos Vyletel
2014-06-10 16:19 ` [patch net-next 5/5] ipv6: copy default config values to interfaces Milos Vyletel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140611.153225.671693159592497903.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Paul.Durrant@citrix.com \
--cc=amwang@redhat.com \
--cc=dborkman@redhat.com \
--cc=edumazet@google.com \
--cc=florent.fourcot@enst-bretagne.fr \
--cc=hannes@stressinduktion.org \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mike.rapoport@ravellosystems.com \
--cc=milos.vyletel@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=ogerlitz@mellanox.com \
--cc=oliver@neukum.org \
--cc=pshelar@nicira.com \
--cc=stephen@networkplumber.org \
--cc=therbert@google.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®