From: Mark Brown <broonie@kernel.org>
To: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Cc: Richard Fitzgerald <rf@opensource.wolfsonmicro.com>,
sameo@linux.intel.com, lee.jones@linaro.org, lgirdwood@gmail.com,
perex@perex.cz, tiwai@suse.de, alsa-devel@alsa-project.org,
patches@opensource.wolfsonmicro.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] regulator: arizona-ldo1: Do not control clocking from regulator
Date: Wed, 11 Jun 2014 14:54:48 +0100 [thread overview]
Message-ID: <20140611135448.GH5099@sirena.org.uk> (raw)
In-Reply-To: <20140611105926.GB12074@opensource.wolfsonmicro.com>
[-- Attachment #1: Type: text/plain, Size: 941 bytes --]
On Wed, Jun 11, 2014 at 11:59:26AM +0100, Charles Keepax wrote:
> On Mon, Jun 09, 2014 at 07:43:14PM +0100, Mark Brown wrote:
> > IIRC this was deliberately coded in this fashion on advice from the
> > hardware engineers - there was more going on with that register than
> > there might at first appear and some actual sync with the LDO. I
> > believe there was some different process to follow (possibly just
> > setting this mode all the time) when using an external regulator, though
> > it's also possible the hardware guys were just unsure at the time.
> I have had a good chat with the hardware engineers here and they
> are pretty adamant that the only constraint here is that we
> should never enable SUBSYS without 1.8V being supplied to the
> core.
OK, that sounds like the advice when the device was first produced was
not accurate - might be worth checking your datasheets here. Might also
be worth updating the commit log.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2014-06-11 13:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-09 15:00 [PATCH 0/4] arizona: Improvements to codec DVFS control Richard Fitzgerald
2014-06-09 15:02 ` [PATCH 1/4] mfd: arizona: Export function to control subsystem DVFS Richard Fitzgerald
2014-06-16 16:42 ` Lee Jones
2014-06-16 16:48 ` Mark Brown
2014-06-16 17:09 ` Charles Keepax
2014-06-16 17:06 ` Charles Keepax
2014-06-09 15:03 ` [PATCH 2/4] ASoC: wm_adsp: Move DVFS control into codec driver Richard Fitzgerald
2014-06-11 10:54 ` Charles Keepax
2014-06-09 15:03 ` [PATCH 3/4] ASoC: arizona: Add DVFS handling for sample rate control Richard Fitzgerald
2014-06-09 15:04 ` [PATCH 4/4] regulator: arizona-ldo1: Do not control clocking from regulator Richard Fitzgerald
2014-06-09 18:43 ` Mark Brown
2014-06-11 10:59 ` Charles Keepax
2014-06-11 13:54 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140611135448.GH5099@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
--cc=perex@perex.cz \
--cc=rf@opensource.wolfsonmicro.com \
--cc=sameo@linux.intel.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®