From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932350AbaFKQzA (ORCPT ); Wed, 11 Jun 2014 12:55:00 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:56993 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751049AbaFKQy7 (ORCPT ); Wed, 11 Jun 2014 12:54:59 -0400 Date: Wed, 11 Jun 2014 09:54:55 -0700 From: Christoph Hellwig To: "Martin K. Petersen" Cc: axboe@fb.com, nab@daterainc.com, sagig@dev.mellanox.co.il, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-api@vger.kernel.org Subject: Re: [PATCH 12/14] block: Add specific data integrity errors Message-ID: <20140611165455.GG9511@infradead.org> References: <1401334128-15499-1-git-send-email-martin.petersen@oracle.com> <1401334128-15499-13-git-send-email-martin.petersen@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1401334128-15499-13-git-send-email-martin.petersen@oracle.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 28, 2014 at 11:28:46PM -0400, Martin K. Petersen wrote: > Introduce a set of error codes that can be used by the block integrity > subsystem to signal which class of error was encountered by either the > I/O controller or the storage device. > > Signed-off-by: Martin K. Petersen New error code should be run past linux-kernel and linux-api. I'd also love to see something catching these so that they don't leak to userspace. In fact I'd really prefer to not overload the errno space with something so block specific if possible - we use very few errnos in the bio/request errors, and cleaning them up to use a block-specific error type would be the best solution.