From: Mark Brown <broonie@kernel.org>
To: Jassi Brar <jaswinder.singh@linaro.org>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
mporter@linaro.org, patches@linaro.org, bjorn@kryo.se,
ashwin.chaugule@linaro.org, gregkh@linuxfoundation.org,
s-anna@ti.com, loic.pallardy@st.com, lftan.linux@gmail.com,
slapdau@yahoo.com.au, courtney.cavin@sonymobile.com,
pawel.moll@arm.com, robh+dt@kernel.org, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, arnd@arndb.de,
joshc@codeaurora.org, linus.walleij@linaro.org,
galak@codeaurora.org, ks.giri@samsung.com
Subject: Re: [PATCHv7 2/5] mailbox: Introduce framework for mailbox
Date: Fri, 13 Jun 2014 21:40:27 +0100 [thread overview]
Message-ID: <20140613204027.GC5099@sirena.org.uk> (raw)
In-Reply-To: <1402592479-7244-1-git-send-email-jaswinder.singh@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 681 bytes --]
On Thu, Jun 12, 2014 at 10:31:19PM +0530, Jassi Brar wrote:
A couple of tiny nits, I'll send followup patches for these.
> +bool mbox_client_peek_data(struct mbox_chan *chan)
> +{
> + if (chan->mbox->ops->peek_data)
> + return chan->mbox->ops->peek_data(chan);
> +
> + return false;
> +}
> +EXPORT_SYMBOL_GPL(mbox_client_peek_data);
This isn't declared in the header to allow users to use it.
> +struct mbox_chan *mbox_request_channel(const struct mbox_client *cl)
> + spin_lock_irqsave(&chan->lock, flags);
> + chan->msg_free = 0;
> + chan->msg_count = 0;
> + chan->active_req = NULL;
> + chan->cl = cl;
chan->cl is non-const but cl is const so this assignment is invalid.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-06-13 20:40 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-12 16:58 [PATCHv7 0/5] Common Mailbox Framework Jassi Brar
2014-06-12 17:00 ` [PATCHv7 1/5] mailbox: rename pl320-ipc specific mailbox.h Jassi Brar
2014-06-12 17:01 ` [PATCHv7 2/5] mailbox: Introduce framework for mailbox Jassi Brar
2014-06-13 20:40 ` Mark Brown [this message]
2014-06-18 0:27 ` Kevin Hilman
2014-06-18 8:33 ` Jassi Brar
2014-06-18 17:03 ` Kevin Hilman
2014-06-19 2:55 ` Jassi Brar
2014-06-19 12:14 ` Ashwin Chaugule
2014-06-19 12:36 ` Sudeep Holla
2014-06-19 18:17 ` Sudeep Holla
[not found] ` <20140619190342.GT4173@beef>
2014-06-19 20:29 ` Jassi Brar
2014-06-19 20:40 ` Matt Porter
2014-06-20 18:05 ` Lubomir Rintel
2014-06-22 10:56 ` Lubomir Rintel
2014-06-12 17:01 ` [PATCHv7 3/5] Mailbox: Generic: Specify mailbox api bindings Jassi Brar
2014-06-12 17:02 ` [PATCHv7 4/5] mailbox: Fix deleteing poll timer Jassi Brar
2014-06-12 17:02 ` [PATCHv7 5/5] MAINTAINERS: Add maintainer entry for Mailbox API Jassi Brar
2014-06-30 16:16 ` [PATCHv7 0/5] Common Mailbox Framework Lubomir Rintel
2014-06-30 16:22 ` Jassi Brar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140613204027.GC5099@sirena.org.uk \
--to=broonie@kernel.org \
--cc=arnd@arndb.de \
--cc=ashwin.chaugule@linaro.org \
--cc=bjorn@kryo.se \
--cc=courtney.cavin@sonymobile.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=gregkh@linuxfoundation.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jaswinder.singh@linaro.org \
--cc=joshc@codeaurora.org \
--cc=ks.giri@samsung.com \
--cc=lftan.linux@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.pallardy@st.com \
--cc=mark.rutland@arm.com \
--cc=mporter@linaro.org \
--cc=patches@linaro.org \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=s-anna@ti.com \
--cc=slapdau@yahoo.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome