From: "George Spelvin" <linux@horizon.com>
To: linux-kernel@vger.kernel.org, tytso@mit.edu
Cc: linux@horizon.com
Subject: Re: [PATCH-v2 4/4] random: clean up interrupt entropy accounting for archs w/o cycle counters
Date: 14 Jun 2014 03:28:49 -0400 [thread overview]
Message-ID: <20140614072849.27887.qmail@ns.horizon.com> (raw)
In-Reply-To: <1402730118-23122-4-git-send-email-tytso@mit.edu>
+ if (cycles || (fast_pool->notimer_count >= 32))
+ credit++;
Ah, this addresses my concern about too few interrupts, too. If the
(non-timer) interrupt rate is less than 32/second, you'll never get any
credit.
(If you want to support this mode of operation and still have a non-zero
credit rate, move the clear of notimer_count into this condition. Then
you get 1 bit per 32 non-timer interrupts no matter how slow.)
next prev parent reply other threads:[~2014-06-14 7:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-14 7:15 [PATCH-v2 1/4] random: always update the entropy pool under the spinlock Theodore Ts'o
2014-06-14 7:15 ` [PATCH-v2 2/4] random: remove unneeded hash of a portion of the entropy pool Theodore Ts'o
2014-06-14 7:15 ` [PATCH-v2 3/4] random: only update the last_pulled time if we actually transferred entropy Theodore Ts'o
2014-06-14 7:15 ` [PATCH-v2 4/4] random: clean up interrupt entropy accounting for archs w/o cycle counters Theodore Ts'o
2014-06-14 7:28 ` George Spelvin [this message]
2014-06-14 16:00 ` Theodore Ts'o
2014-06-14 16:23 ` George Spelvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140614072849.27887.qmail@ns.horizon.com \
--to=linux@horizon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®