mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Theodore Ts'o" <tytso@mit.edu>
To: Linux Kernel Developers List <linux-kernel@vger.kernel.org>,
	George Spelvin <linux@horizon.com>
Subject: Re: Surprising 64-bit performance anomaly (was Re: [PATCH] random: use an improved fast_mix() function)
Date: Sat, 14 Jun 2014 23:19:13 -0400	[thread overview]
Message-ID: <20140615031913.GB8111@thunk.org> (raw)
In-Reply-To: <20140615030441.GA8111@thunk.org>

On Sat, Jun 14, 2014 at 11:04:41PM -0400, Theodore Ts'o wrote:
> Hi George,
> 
> On top of the above patch, I applied the following to add 64-bit pool
> support.  I had to use a union to avoid type punning warnings.
> 
> When building a 64-bit kernel and running under under KVM, I'm finding
> that the 64-bit mix function which you suggested is twice as slow.
> 
> Using the (new) 32-bit function:
> 
> 31821 23970
> 31629 24366
> 30856 24182
> 
> Using the 64-bit mixing function:
> 
> 60438 44369
> 60820 45402
> 58778 45419

I'm now getting a different set of timing numbers for the 64-bit
mixing function.  As before the first number is the weighted moving
average; the second is the deviation:

48035 34322
47452 34413
46974 34350

I'm not sure why I'm getting slightly better figures now, but it's
still worse than the 32-bit fast_mix3() algorithm.  Also, given the
additional complexity I'm not sure it's worth it to have a different
mixing algorithm for 64-bit platforms, unless it's significantly
better, and right now, I'm seeing numbers which are about 50% worse,
at least on my test platform.

	   	      	      	   	      - Ted

  reply	other threads:[~2014-06-15  3:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-15  2:19 [PATCH] random: use an improved fast_mix() function Theodore Ts'o
2014-06-15  3:04 ` Surprising 64-bit performance anomaly (was Re: [PATCH] random: use an improved fast_mix() function) Theodore Ts'o
2014-06-15  3:19   ` Theodore Ts'o [this message]
2014-06-15  9:07     ` George Spelvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140615031913.GB8111@thunk.org \
    --to=tytso@mit.edu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@horizon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome