mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jiri Pirko <jiri@resnulli.us>
To: David Miller <davem@davemloft.net>
Cc: mprivozn@redhat.com, gregkh@linuxfoundation.org,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] net-sysfs: Report link speed only when possible
Date: Mon, 16 Jun 2014 11:01:18 +0200	[thread overview]
Message-ID: <20140616090118.GB3085@minipsycho.orion> (raw)
In-Reply-To: <20140616.014430.163976160998454211.davem@davemloft.net>

Mon, Jun 16, 2014 at 10:44:30AM CEST, davem@davemloft.net wrote:
>From: Michal Privoznik <mprivozn@redhat.com>
>Date: Mon, 16 Jun 2014 10:30:27 +0200
>
>> On 16.06.2014 10:11, David Miller wrote:
>>> From: Michal Privoznik <mprivozn@redhat.com>
>>> Date: Mon, 16 Jun 2014 09:32:35 +0200
>>>
>>>> On 13.06.2014 22:03, David Miller wrote:
>>>>> From: Michal Privoznik <mprivozn@redhat.com>
>>>>> Date: Fri, 13 Jun 2014 11:19:51 +0200
>>>>>
>>>>>> So if I were developing brand new application I could say: I'm
>>>>>> dropping all this workaround code and have it clean and require say
>>>>>> 3.16 kernel at least.
>>>>>
>>>>> Then your application wouldn't be usable on %99 of systems for a long
>>>>> long time.
>>>>>
>>>>
>>>> How come? The application is going to be usable for as long as
>>>> library/kernel APIs won't change.
>>>
>>> Because %99 of users are using a distribution kernel which is
>>> definitely
>>> going to be pre-3.16 for years.
>>>
>> 
>> That's why every distribution out there has a mechanism to install
>> packages of a certain version, or those providing certain symbol,
>> whatever. Or distributions can then backport some kernel patches or
>> something. But, that's completely unrelated to the problem I'm fixing
>> here. I don't think this bikeshedding is useful for anything, sorry.
>
>You're being entirely impractical.
>
>By restricting an application to a kernel version or behavior "via
>backported patches" which doesn't even exist yet, you are foolishly
>restricting your userbase.
>
>People just cope with what the current kernels support, when possible,
>and that's the right thing to do because we cannot break it on them
>exactly because people can depend upon the behavior.
>
>NOBODY is checking for -EINVAL returns when reading the link speed
>sysfs file, and therefore by signalling it you will break
>applications.
>
>So I will not apply a patch which adds that new behavior, sorry.
>
>I am not willing to discuss this further, this is fundamental and
>simple as far as I'm concerned.
>

Let's just hope we do not introduce some other, more serious bug
somewhere else in user api. I see that such things are unfixable :/

      parent reply	other threads:[~2014-06-16  9:01 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-06  8:40 Michal Privoznik
2014-06-06  8:57 ` Jiri Pirko
2014-06-06 19:54   ` David Miller
2014-06-13  9:19     ` Michal Privoznik
2014-06-13 20:03       ` David Miller
2014-06-16  7:32         ` Michal Privoznik
2014-06-16  8:11           ` David Miller
2014-06-16  8:30             ` Michal Privoznik
2014-06-16  8:44               ` David Miller
2014-06-16  8:59                 ` Michal Privoznik
2014-06-16  9:01                 ` Jiri Pirko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140616090118.GB3085@minipsycho.orion \
    --to=jiri@resnulli.us \
    --cc=davem@davemloft.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mprivozn@redhat.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®