From: Lee Jones <lee.jones@linaro.org>
To: Laxman Dewangan <ldewangan@nvidia.com>
Cc: robh+dt@kernel.org, swarren@nvidia.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
mark.rutland@arm.com, linus.walleij@linaro.org
Subject: Re: [PATCH] Doc: mfd: as3722: Add details of optional missing property
Date: Mon, 16 Jun 2014 10:52:56 +0100 [thread overview]
Message-ID: <20140616095256.GN14323@lee--X1> (raw)
In-Reply-To: <1402297417-9338-1-git-send-email-ldewangan@nvidia.com>
CC'ing Linus as he had an opinion.
On Mon, 09 Jun 2014, Laxman Dewangan wrote:
> Add details of following properties which are used on driver but
> not documented on DT binding document.
> - ams,enable-internal-int-pullup
> - ams,enable-internal-i2c-pullup
>
> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
> Reported-by: Lee Jones <lee.jones@linaro.org>
> ---
> Documentation/devicetree/bindings/mfd/as3722.txt | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mfd/as3722.txt b/Documentation/devicetree/bindings/mfd/as3722.txt
> index 8edcb9b..4f64b2a 100644
> --- a/Documentation/devicetree/bindings/mfd/as3722.txt
> +++ b/Documentation/devicetree/bindings/mfd/as3722.txt
> @@ -13,6 +13,14 @@ Required properties:
> The second cell is the flags, encoded as the trigger masks from binding document
> interrupts.txt, using dt-bindings/irq.
>
> +Optional properties:
> +--------------------
> +- ams,enable-internal-int-pullup: Boolean property, to enable internal pullup on
> + interrupt pin. Missing this will disable internal pullup on INT pin.
> +- ams,enable-internal-i2c-pullup: Boolean property, to enable internal pullup on
> + i2c scl/sda pins. Missing this will disable internal pullup on i2c
> + scl/sda lines.
> +
> Optional submodule and their properties:
> =======================================
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2014-06-16 9:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-09 7:03 Laxman Dewangan
2014-06-16 9:52 ` Lee Jones [this message]
2014-07-07 10:49 ` Linus Walleij
2014-07-09 15:34 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140616095256.GN14323@lee--X1 \
--to=lee.jones@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=ldewangan@nvidia.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=swarren@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®