Re: [PATCH] mfd: tc3589x: translate onecell, not twocell

[Lee Jones <lee.jones@linaro.org>]

On Tue, 10 Jun 2014, Linus Walleij wrote:

> Something changed in the OF parser in the v3.16 merge window
> making it be strict about passing the number of IRQ cells
> correctly and disturbing the irqdomain xlate function guard
> to crash when subdevices try to obtain IRQs like this:

[...]

> The TC3589x device trees specify the MFD core device
> as having one interrupt cell (cannot specify flags) so the
> twocell translation function is clearly wrong, changing it to
> onecell, as it should be, fixes the regression.
> 
> Cc: Lee Jones <lee.jones@linaro.org>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
>  drivers/mfd/tc3589x.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Looks good.  Applied, thanks.

> diff --git a/drivers/mfd/tc3589x.c b/drivers/mfd/tc3589x.c
> index bd83accc0f6d..0072e668c208 100644
> --- a/drivers/mfd/tc3589x.c
> +++ b/drivers/mfd/tc3589x.c
> @@ -236,7 +236,7 @@ static void tc3589x_irq_unmap(struct irq_domain *d, unsigned int virq)
>  static struct irq_domain_ops tc3589x_irq_ops = {
>  	.map    = tc3589x_irq_map,
>  	.unmap  = tc3589x_irq_unmap,
> -	.xlate  = irq_domain_xlate_twocell,
> +	.xlate  = irq_domain_xlate_onecell,
>  };
>  
>  static int tc3589x_irq_init(struct tc3589x *tc3589x, struct device_node *np)

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog