From: Fabian Frederick <fabf@skynet.be>
To: Bob Copeland <me@bobcopeland.com>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH V2] fs/omfs/inode.c: use ULLONG_MAX instead of ~0ULL
Date: Mon, 16 Jun 2014 20:59:19 +0200 [thread overview]
Message-ID: <20140616205919.5740bea0522043fdfd32e98c@skynet.be> (raw)
In-Reply-To: <20140615161142.GC15404@localhost>
On Sun, 15 Jun 2014 12:11:42 -0400
Bob Copeland <me@bobcopeland.com> wrote:
> On Sun, Jun 15, 2014 at 08:39:20AM +0200, Fabian Frederick wrote:
> > Use more explicit kernel.h definition
> > array_size = DIV_ROUND_UP(bitmap_size, sb->s_blocksize);
> >
> > - if (sbi->s_bitmap_ino == ~0ULL)
> > + if (sbi->s_bitmap_ino == ULLONG_MAX)
> > goto out;
>
> So I agree they are the same, but is there a good reason for the
> change?
>
> Semantically, I think of ~0ULL as "all ones" whereas ULLONG_MAX
> as a maximum of a magnitude comparison, which this is not really.
Well it was meant to clarify code but in this case it doesn't indeed :)
Thanks,
Fabian
>
> --
> Bob Copeland %% www.bobcopeland.com
prev parent reply other threads:[~2014-06-16 19:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-15 6:39 Fabian Frederick
2014-06-15 16:11 ` Bob Copeland
2014-06-16 18:59 ` Fabian Frederick [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140616205919.5740bea0522043fdfd32e98c@skynet.be \
--to=fabf@skynet.be \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=me@bobcopeland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®