From: "Jörn Engel" <joern@logfs.org>
To: Nick Krause <xerofoify@gmail.com>
Cc: Mateusz Guzik <mguzik@redhat.com>,
Prasad Joshi <prasadjoshi.linux@gmail.com>,
logfs@logfs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Check for Null return from logfs_readpage_nolock in btree_write_block
Date: Mon, 16 Jun 2014 21:20:50 -0400 [thread overview]
Message-ID: <20140617012050.GB14467@logfs.org> (raw)
In-Reply-To: <CAPDOMVgDUgfr9oqGmQ2a6u9Jm0eyBP=RP8EbCuHmnu-MRb+=+w@mail.gmail.com>
On Mon, 16 June 2014 20:46:32 -0400, Nick Krause wrote:
>
> You are right about the compile errors it compiles but with warning.
> I am curious since the function is void how do you want me to
> give the error back to logfs and in turn the other subsystems
> of the kernel.
My first question would be: What is the problem? If there is no
problem, don't try to fix it. If there is a problem, your fix should
contain a decent description of the problem as part of the commit
message. Even if the patch itself ends up being bad, having a good
problem description with a first stab at a fix serves as a useful bug
report.
Jörn
--
Was there any time in human history where democratic forms continued
when the citizens could not credibly defend their rights?
-- Daniel Suarez
prev parent reply other threads:[~2014-06-17 1:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-16 19:47 Nicholas Krause
2014-06-16 20:06 ` Mateusz Guzik
[not found] ` <CAPDOMVgDUgfr9oqGmQ2a6u9Jm0eyBP=RP8EbCuHmnu-MRb+=+w@mail.gmail.com>
2014-06-17 1:20 ` Jörn Engel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140617012050.GB14467@logfs.org \
--to=joern@logfs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=logfs@logfs.org \
--cc=mguzik@redhat.com \
--cc=prasadjoshi.linux@gmail.com \
--cc=xerofoify@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome