From: Peter Zijlstra <peterz@infradead.org>
To: Tim Chen <tim.c.chen@linux.intel.com>
Cc: Ingo Molnar <mingo@elte.hu>, Andi Kleen <andi@firstfloor.org>,
Michel Lespinasse <walken@google.com>,
Rik van Riel <riel@redhat.com>,
Peter Hurley <peter@hurleysoftware.com>,
Jason Low <jason.low2@hp.com>,
Davidlohr Bueson <davidlohr@hp.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sched: Fast idling of CPU when system is partially loaded
Date: Tue, 17 Jun 2014 14:09:38 +0200 [thread overview]
Message-ID: <20140617120938.GN3213@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1402933807.2970.577.camel@schen9-DESK>
[-- Attachment #1: Type: text/plain, Size: 645 bytes --]
On Mon, Jun 16, 2014 at 08:50:07AM -0700, Tim Chen wrote:
> > The worry I have is that this update is 'slow'. We could have grown many
> > tasks since the last update.
>
> The update to turn on the indicator is immediate and triggered in
> add_nr_running. So if there are more than one tasks on any cpu,
> we start load balancing again right away. It is only the
> clearing of the indicator in update_sd_lb_stats that takes time.
> That does no harm as the cleared indicator is for the skipping of load
> balance, which can be delayed.
>
Oh right, shows me I shouldn't be reading patches on sunday or similarly
daft times ;)
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2014-06-17 12:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-12 21:25 Tim Chen
2014-06-13 6:01 ` Jason Low
2014-06-13 16:28 ` Tim Chen
2014-06-13 19:18 ` Jason Low
2014-06-13 20:17 ` Tim Chen
2014-06-15 16:19 ` Peter Zijlstra
2014-06-16 15:50 ` Tim Chen
2014-06-17 12:09 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140617120938.GN3213@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=andi@firstfloor.org \
--cc=davidlohr@hp.com \
--cc=jason.low2@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peter@hurleysoftware.com \
--cc=riel@redhat.com \
--cc=tim.c.chen@linux.intel.com \
--cc=walken@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome