From: Mark Brown <broonie@kernel.org>
To: Robert Jarzmik <robert.jarzmik@free.fr>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] regulator: max1586 add device-tree support
Date: Tue, 17 Jun 2014 15:43:23 +0100 [thread overview]
Message-ID: <20140617144323.GU5099@sirena.org.uk> (raw)
In-Reply-To: <1402757665-15102-1-git-send-email-robert.jarzmik@free.fr>
[-- Attachment #1: Type: text/plain, Size: 386 bytes --]
On Sat, Jun 14, 2014 at 04:54:24PM +0200, Robert Jarzmik wrote:
> + matched = of_regulator_match(dev, np, rmatch, ARRAY_SIZE(rmatch));
> + of_node_put(np);
> + if (matched <= 0)
> + return matched;
Why is this treating zero as an error? We should be able to at least
report the current state of regulators even if none are configured in
the device tree.
Otherwise this looks good.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-06-17 14:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-14 14:54 Robert Jarzmik
2014-06-14 14:54 ` [PATCH 2/2] " Robert Jarzmik
2014-06-17 14:43 ` Mark Brown [this message]
2014-06-17 19:16 ` [PATCH 1/2] " Robert Jarzmik
2014-06-24 15:38 ` Mark Brown
2014-06-24 18:05 ` Robert Jarzmik
2014-06-24 23:15 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140617144323.GU5099@sirena.org.uk \
--to=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robert.jarzmik@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®