From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756143AbaFSNoW (ORCPT ); Thu, 19 Jun 2014 09:44:22 -0400 Received: from cdptpa-outbound-snat.email.rr.com ([107.14.166.226]:51281 "EHLO cdptpa-oedge-vip.email.rr.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755967AbaFSNoU (ORCPT ); Thu, 19 Jun 2014 09:44:20 -0400 Date: Thu, 19 Jun 2014 09:44:16 -0400 From: Steven Rostedt To: Mike Galbraith Cc: LKML , linux-rt-users , Thomas Gleixner , Carsten Emde , John Kacur , Sebastian Andrzej Siewior Subject: Re: [ANNOUNCE] 3.12.22-rt33 Message-ID: <20140619094416.302f5ef3@gandalf.local.home> In-Reply-To: <1403149603.5189.10.camel@marge.simpson.net> References: <20140618201233.4dd3a59d@gandalf.local.home> <1403149603.5189.10.camel@marge.simpson.net> X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.23; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-RR-Connecting-IP: 107.14.168.118:25 X-Cloudmark-Score: 0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 19 Jun 2014 05:46:43 +0200 Mike Galbraith wrote: > On Wed, 2014-06-18 at 20:12 -0400, Steven Rostedt wrote: > > Dear RT Folks, > > > > I'm pleased to announce the 3.12.22-rt33 stable release. Didn't we have this issue before? > > > git@marge:~/linux-2.6> git diff v3.12... drivers/net/ethernet/dec/tulip/tulip_core.c > diff --git a/drivers/net/ethernet/dec/tulip/tulip_core.c b/drivers/net/ethernet/dec/tulip/tulip_core.c > index 4e8cfa2ac803..a6d4653ebbc3 100644 > --- a/drivers/net/ethernet/dec/tulip/tulip_core.c > +++ b/drivers/net/ethernet/dec/tulip/tulip_core.c > @@ -1939,7 +1939,9 @@ static void tulip_remove_one(struct pci_dev *pdev) > pci_iounmap(pdev, tp->base_addr); > free_netdev (dev); > pci_release_regions (pdev); > + pci_disable_device(pdev); > pci_set_drvdata (pdev, NULL); > + pci_disable_device(pdev); > > /* pci_power_off (pdev, -1); */ > } > > commit 4a77edc195f0b03644e84dda00fcfe9827868e8e > Author: Ingo Molnar > Date: Fri Jul 3 08:30:18 2009 -0500 > > drivers/net: tulip_remove_one needs to call pci_disable_device() > > Otherwise the device is not completely shut down. Grumble, this was a fix that went into -rt without going into stable first. OK, I'll remove this commit and keep the stable one. Thanks! -- Steve > > Signed-off-by: Ingo Molnar > Signed-off-by: Thomas Gleixner > > diff --git a/drivers/net/ethernet/dec/tulip/tulip_core.c b/drivers/net/ethernet/dec/tulip/tulip_core.c > index 4e8cfa2ac803..7565b994ec50 100644 > --- a/drivers/net/ethernet/dec/tulip/tulip_core.c > +++ b/drivers/net/ethernet/dec/tulip/tulip_core.c > @@ -1939,6 +1939,7 @@ static void tulip_remove_one(struct pci_dev *pdev) > pci_iounmap(pdev, tp->base_addr); > free_netdev (dev); > pci_release_regions (pdev); > + pci_disable_device(pdev); > pci_set_drvdata (pdev, NULL); > > /* pci_power_off (pdev, -1); */ > > > commit 831bb5573dcbeb0da783c82e21084ac191dafc24 > Author: Ingo Molnar > Date: Fri Feb 14 15:32:20 2014 +0100 > > drivers/net: tulip_remove_one needs to call pci_disable_device() > > commit c321f7d7c87cdc623c87845f6378620573e57512 upstream. > > Otherwise the device is not completely shut down. > > Signed-off-by: Ingo Molnar > Signed-off-by: Thomas Gleixner > Signed-off-by: Sebastian Andrzej Siewior > Signed-off-by: David S. Miller > Signed-off-by: Jiri Slaby > > diff --git a/drivers/net/ethernet/dec/tulip/tulip_core.c b/drivers/net/ethernet/dec/tulip/tulip_core.c > index 4e8cfa2ac803..779016068a82 100644 > --- a/drivers/net/ethernet/dec/tulip/tulip_core.c > +++ b/drivers/net/ethernet/dec/tulip/tulip_core.c > @@ -1940,6 +1940,7 @@ static void tulip_remove_one(struct pci_dev *pdev) > free_netdev (dev); > pci_release_regions (pdev); > pci_set_drvdata (pdev, NULL); > + pci_disable_device(pdev); > > /* pci_power_off (pdev, -1); */ > } >