From: Tejun Heo <tj@kernel.org>
To: Lai Jiangshan <laijs@cn.fujitsu.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] workqueue: use "pool->cpu < 0" to stand for an unbound pool
Date: Thu, 19 Jun 2014 12:15:53 -0400 [thread overview]
Message-ID: <20140619161553.GI26904@htj.dyndns.org> (raw)
In-Reply-To: <1401780714-12127-1-git-send-email-laijs@cn.fujitsu.com>
On Tue, Jun 03, 2014 at 03:31:45PM +0800, Lai Jiangshan wrote:
> There is a piece of sanity checks code in the put_unbound_pool().
> The meaning of this code is "if it is not an unbound pool, it will complain
> and return" IIUC. But the code uses "pool->flags & POOL_DISASSOCIATED"
> imprecisely due to a non-unbound pool may also have this flags.
>
> We should use "pool->cpu < 0" to stand for an unbound pool, so we covert the
> code to it.
>
> There is no strictly wrong if we still keep "pool->flags & POOL_DISASSOCIATED"
> here, but it is just a noise if we keep it:
> 1) we focus on "unbound" here, not "[dis]association".
> 2) "pool->cpu < 0" already implies "pool->flags & POOL_DISASSOCIATED".
>
> Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
Applied to wq/for-3.17.
Thansk.
--
tejun
prev parent reply other threads:[~2014-06-19 16:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-03 7:31 Lai Jiangshan
2014-06-05 1:20 ` Lai Jiangshan
2014-06-05 1:17 ` Tejun Heo
2014-06-05 1:40 ` Lai Jiangshan
2014-06-17 1:32 ` Lai Jiangshan
2014-06-19 16:15 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140619161553.GI26904@htj.dyndns.org \
--to=tj@kernel.org \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®