From: Tejun Heo <tj@kernel.org>
To: Christoph Lameter <cl@gentwo.org>
Cc: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
David Howells <dhowells@redhat.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Oleg Nesterov <oleg@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC] percpu: add data dependency barrier in percpu accessors and operations
Date: Thu, 19 Jun 2014 16:46:34 -0400 [thread overview]
Message-ID: <20140619204634.GB9814@mtj.dyndns.org> (raw)
In-Reply-To: <alpine.DEB.2.11.1406191540240.4002@gentwo.org>
On Thu, Jun 19, 2014 at 03:42:07PM -0500, Christoph Lameter wrote:
> In that case special care needs to be taken to get this right. True.
>
> I typically avoid these scenarios by sending an IPI with a pointer to the
> data structure. The modification is done by the cpu for which the per cpu
> data is local.
>
> Maybe rewrite the code to avoid writing to other processors percpu data
> would be the right approach?
It depends on the specific use case but in general no. IPIs would be
far more expensive than making use of proper barriers in vast majority
of cases especially when the "hot" side is data dependency barrier,
IOW, nothing. Also, we are talking about extremely low frequency
events like init and recycling after reinit. Regular per-cpu
operation isn't really the subject here.
Thanks.
--
tejun
next prev parent reply other threads:[~2014-06-19 20:46 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-12 13:56 Tejun Heo
2014-06-12 15:34 ` Paul E. McKenney
2014-06-12 15:52 ` Tejun Heo
2014-06-17 14:41 ` Paul E. McKenney
2014-06-17 15:27 ` Tejun Heo
2014-06-17 15:56 ` Christoph Lameter
2014-06-17 16:00 ` Tejun Heo
2014-06-17 16:05 ` Tejun Heo
2014-06-17 16:28 ` Christoph Lameter
[not found] ` <CA+55aFxHr8JXwDR-4g4z1mkXvZRtY=OosYcUMPZRD2upfooS1w@mail.gmail.com>
2014-06-17 18:47 ` Christoph Lameter
2014-06-17 18:55 ` Paul E. McKenney
2014-06-17 19:39 ` Christoph Lameter
2014-06-17 19:47 ` Tejun Heo
2014-06-17 19:56 ` Paul E. McKenney
2014-06-19 20:39 ` Christoph Lameter
2014-06-17 16:57 ` Paul E. McKenney
2014-06-17 18:56 ` Tejun Heo
2014-06-17 19:42 ` Christoph Lameter
2014-06-17 20:44 ` Tejun Heo
2014-07-09 0:55 ` Rusty Russell
2014-07-14 11:39 ` Paul E. McKenney
2014-07-14 15:22 ` Christoph Lameter
2014-07-15 10:11 ` Paul E. McKenney
2014-07-15 14:06 ` Christoph Lameter
2014-07-15 14:32 ` Paul E. McKenney
2014-07-15 15:06 ` Christoph Lameter
2014-07-15 15:41 ` Linus Torvalds
2014-07-15 16:12 ` Christoph Lameter
[not found] ` <CA+55aFxU166V5-vH4vmK9OBdTZKyede=71RjjbOVSN9Qh+Se+A@mail.gmail.com>
2014-07-15 17:45 ` Paul E. McKenney
2014-07-15 17:41 ` Paul E. McKenney
2014-07-16 14:40 ` Christoph Lameter
2014-07-15 11:50 ` Rusty Russell
2014-06-17 19:27 ` Christoph Lameter
2014-06-17 19:40 ` Paul E. McKenney
2014-06-19 20:42 ` Christoph Lameter
2014-06-19 20:46 ` Tejun Heo [this message]
2014-06-19 21:11 ` Christoph Lameter
2014-06-19 21:15 ` Tejun Heo
2014-06-20 15:23 ` Christoph Lameter
2014-06-20 15:52 ` Tejun Heo
2014-06-19 20:51 ` Paul E. McKenney
2014-06-20 15:29 ` Christoph Lameter
2014-06-20 15:50 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140619204634.GB9814@mtj.dyndns.org \
--to=tj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=cl@gentwo.org \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®