From: Steven Rostedt <rostedt@goodmis.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Jiri Kosina <jkosina@suse.cz>, Michal Hocko <mhocko@suse.cz>,
Jan Kara <jack@suse.cz>, Frederic Weisbecker <fweisbec@gmail.com>,
Dave Anderson <anderson@redhat.com>,
Petr Mladek <pmladek@suse.cz>
Subject: Re: [RFC][PATCH 1/3] trace_seq: Move the trace_seq code to lib/
Date: Fri, 20 Jun 2014 12:21:35 -0400 [thread overview]
Message-ID: <20140620122135.17a90bfb@gandalf.local.home> (raw)
In-Reply-To: <CA+55aFx_BVK6EvMTcTy218coYEhvMdw3AkygDtiZk5aHxa-fuA@mail.gmail.com>
On Thu, 19 Jun 2014 18:45:57 -1000
Linus Torvalds <torvalds@linux-foundation.org> wrote:
> On Thu, Jun 19, 2014 at 11:33 AM, Steven Rostedt <rostedt@goodmis.org> wrote:
> > From: "Steven Rostedt (Red Hat)" <rostedt@goodmis.org>
> >
> > The trace_seq functions are rather useful outside of tracing.
>
> They are?
They will be.
> Why and where?
Why? for NMI safe output.
Where? Well, in patch 3. :-)
> And why are they still called "trace_xyz()" then?
Good point, I'd like to rename it too. It was designed like seq_file,
so what about seq_buffer_xxx()?
>
> That commit message is useless and contains no actual information.
Yeah, it was rather weak. It was quick and not a stand alone. It was
dependent on reading the rest of the patches.
OK, I can update the name and make a better change log on the move.
Of course if you hate this patch series, I can just not waste any time
on it.
-- Steve
next prev parent reply other threads:[~2014-06-20 16:21 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-19 21:33 [RFC][PATCH 0/3] x86/nmi: Print all cpu stacks from NMI safely Steven Rostedt
2014-06-19 21:33 ` [RFC][PATCH 1/3] trace_seq: Move the trace_seq code to lib/ Steven Rostedt
2014-06-20 4:45 ` Linus Torvalds
2014-06-20 16:21 ` Steven Rostedt [this message]
2014-06-20 5:06 ` Andrew Morton
2014-06-20 16:58 ` Steven Rostedt
2014-06-20 17:12 ` Andrew Morton
2014-06-20 17:17 ` Steven Rostedt
2014-06-20 20:28 ` Steven Rostedt
2014-06-20 20:51 ` Steven Rostedt
2014-06-23 16:33 ` Petr Mládek
2014-06-23 17:03 ` Steven Rostedt
2014-06-22 7:38 ` Johannes Berg
2014-06-23 16:08 ` Steven Rostedt
2014-06-23 17:38 ` Johannes Berg
2014-06-23 18:04 ` Steven Rostedt
2014-06-24 8:19 ` Johannes Berg
2014-06-19 21:33 ` [RFC][PATCH 2/3] printk: Add per_cpu printk func to allow printk to be diverted Steven Rostedt
2014-06-23 16:06 ` Paul E. McKenney
2014-06-19 21:33 ` [RFC][PATCH 3/3] x86/nmi: Perform a safe NMI stack trace on all CPUs Steven Rostedt
2014-06-20 13:58 ` Don Zickus
2014-06-20 14:21 ` Steven Rostedt
2014-06-20 14:55 ` Petr Mládek
2014-06-20 15:17 ` Steven Rostedt
2014-06-23 16:12 ` Paul E. McKenney
2014-06-19 21:56 ` [RFC][PATCH 0/3] x86/nmi: Print all cpu stacks from NMI safely Jiri Kosina
2014-06-19 22:58 ` Steven Rostedt
2014-06-19 23:03 ` Jiri Kosina
2014-06-19 23:19 ` Steven Rostedt
2014-06-19 23:27 ` Jiri Kosina
2014-06-19 23:36 ` Steven Rostedt
2014-06-19 23:38 ` Jiri Kosina
2014-06-20 14:35 ` Petr Mládek
2014-06-24 13:32 ` Konstantin Khlebnikov
2014-06-25 10:01 ` Jiri Kosina
2014-06-25 11:04 ` Konstantin Khlebnikov
2014-06-25 11:57 ` Petr Mládek
2014-06-25 12:21 ` Petr Mládek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140620122135.17a90bfb@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=anderson@redhat.com \
--cc=fweisbec@gmail.com \
--cc=jack@suse.cz \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=mhocko@suse.cz \
--cc=mingo@kernel.org \
--cc=pmladek@suse.cz \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®