From: Mark Brown <broonie@kernel.org>
To: Andy Gross <agross@codeaurora.org>
Cc: linux-spi@vger.kernel.org, Sagar Dharia <sdharia@codeaurora.org>,
Daniel Sneddon <dsneddon@codeaurora.org>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org,
"Ivan T. Ivanov" <iivanov@mm-sol.com>,
Bjorn Andersson <bjorn.andersson@sonymobile.com>
Subject: Re: [Patch v2 1/3] spi: qup: Remove chip select function
Date: Sun, 22 Jun 2014 11:47:08 +0100 [thread overview]
Message-ID: <20140622104708.GK24291@sirena.org.uk> (raw)
In-Reply-To: <20140621185646.GA2601@qualcomm.com>
[-- Attachment #1: Type: text/plain, Size: 692 bytes --]
On Sat, Jun 21, 2014 at 01:56:46PM -0500, Andy Gross wrote:
> On Sat, Jun 21, 2014 at 11:13:03AM +0100, Mark Brown wrote:
> > On Thu, Jun 12, 2014 at 02:34:10PM -0500, Andy Gross wrote:
> > > This patch removes the chip select function. Chip select should instead be
> > > supported using GPIOs, defining the DT entry "cs-gpios", and letting the SPI
> > > core assert/deassert the chip select as it sees fit.
> > Why?
> The chip select control inside the controller is buggy. It is supposed to
> automatically assert the chip select based on the activity in the controller,
> but it is buggy and doesn't work at all. So instead we elect to use GPIOs.
OK, though it was in manual mode.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-06-22 10:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-12 19:34 [Patch v2 0/3] spi: qup: Fixes and new version support Andy Gross
2014-06-12 19:34 ` [Patch v2 1/3] spi: qup: Remove chip select function Andy Gross
2014-06-21 10:13 ` Mark Brown
2014-06-21 18:56 ` Andy Gross
2014-06-22 10:47 ` Mark Brown [this message]
2014-06-12 19:34 ` [Patch v2 2/3] spi: qup: Fix order of spi_register_master Andy Gross
2014-06-21 10:12 ` Mark Brown
2014-06-12 19:34 ` [Patch v2 3/3] spi: qup: Add support for v1.1.1 Andy Gross
2014-06-13 16:45 ` Kumar Gala
2014-06-21 10:13 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140622104708.GK24291@sirena.org.uk \
--to=broonie@kernel.org \
--cc=agross@codeaurora.org \
--cc=bjorn.andersson@sonymobile.com \
--cc=dsneddon@codeaurora.org \
--cc=iivanov@mm-sol.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=sdharia@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®