From: Greg KH <greg@kroah.com>
To: Jerry Stralko <gerb.stralko@gmail.com>
Cc: linux-kernel@vger.kernel.org, swetland@google.com
Subject: Re: [PATCH] stagging: android: logger: code cleanup
Date: Sun, 22 Jun 2014 20:41:54 -0400 [thread overview]
Message-ID: <20140623004154.GA7035@kroah.com> (raw)
In-Reply-To: <1403463068-21850-1-git-send-email-gerb.stralko@gmail.com>
On Sun, Jun 22, 2014 at 02:51:08PM -0400, Jerry Stralko wrote:
> Add the unlikey macro to the return value of nonseekable_open,
> since it always returns successfully.
That shouldn't be needed, gcc and the processor knows this already.
Don't use unusual unless you can measure it.
> Fixed up some checkpatch warnings.
Don't do more than one thing in a patch, please split this up.
greg k-h
next prev parent reply other threads:[~2014-06-23 0:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-22 18:51 Jerry Stralko
2014-06-23 0:41 ` Greg KH [this message]
2014-06-24 22:09 Jerry Stralko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140623004154.GA7035@kroah.com \
--to=greg@kroah.com \
--cc=gerb.stralko@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=swetland@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®