From: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
To: Patrick Palka <patrick@parcs.ath.cx>,
Jiri Olsa <jolsa@redhat.com>,
linux-kernel@vger.kernel.org,
Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Ingo Molnar <mingo@redhat.com>, Paul Mackerras <paulus@samba.org>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
Ingo Molnar <mingo@kernel.org>
Subject: [PATCH -tip ] [BUGFIX]: Fix to add a missing pair of braces for error path.
Date: Mon, 23 Jun 2014 03:17:12 +0000 [thread overview]
Message-ID: <20140623031712.6541.39111.stgit@kbuild-fedora.novalocal> (raw)
In-Reply-To: <53A78F14.8070705@hitachi.com>
Fix to add a missing pair of braces for error path.
Commit 36d789a4d75f (perf probe: Improve error message for
unknown member of data structure) introduced this bug.
Without this fix, defining an event with global variables
is always failed, because it always returns -ENOENT if
the argument is not a local variable.
----
# perf probe -na "vfs_read smp_found_config"
Error: Failed to add events.
----
With this fix, you can set a global variable for the
argument of new event.
----
# perf probe -na "vfs_read smp_found_config"
Added new event:
probe:vfs_read (on vfs_read with smp_found_config)
You can now use it in all perf tools, such as:
perf record -e probe:vfs_read -aR sleep 1
----
Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Reported-by: Patrick Palka <patrick@parcs.ath.cx>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
---
tools/perf/util/probe-finder.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tools/perf/util/probe-finder.c b/tools/perf/util/probe-finder.c
index 98e3047..10560fc 100644
--- a/tools/perf/util/probe-finder.c
+++ b/tools/perf/util/probe-finder.c
@@ -572,10 +572,12 @@ static int find_variable(Dwarf_Die *sc_die, struct probe_finder *pf)
/* Search child die for local variables and parameters. */
if (!die_find_variable_at(sc_die, pf->pvar->var, pf->addr, &vr_die)) {
/* Search again in global variables */
- if (!die_find_variable_at(&pf->cu_die, pf->pvar->var, 0, &vr_die))
+ if (!die_find_variable_at(&pf->cu_die, pf->pvar->var, 0,
+ &vr_die)) {
pr_warning("Failed to find '%s' in this function.\n",
pf->pvar->var);
ret = -ENOENT;
+ }
}
if (ret >= 0)
ret = convert_variable(&vr_die, pf);
next prev parent reply other threads:[~2014-06-23 3:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-06 7:13 [PATCH -tip 0/4] perf/probe: Improve error messages Masami Hiramatsu
2014-06-06 7:13 ` [PATCH -tip 1/4] perf/probe: Improve error message for unknown member of data structure Masami Hiramatsu
2014-06-12 12:04 ` [tip:perf/core] perf probe: " tip-bot for Masami Hiramatsu
2014-06-21 18:18 ` [PATCH -tip 1/4] perf/probe: " Patrick Palka
2014-06-23 2:21 ` Masami Hiramatsu
2014-06-23 3:17 ` Masami Hiramatsu [this message]
2014-06-24 7:40 ` [PATCH -tip ] [BUGFIX]: Fix to add a missing pair of braces for error path Namhyung Kim
2014-06-24 9:08 ` Jiri Olsa
2014-06-06 7:13 ` [PATCH -tip 2/4] perf/probe: Show error code and description in verbose mode Masami Hiramatsu
2014-06-12 12:04 ` [tip:perf/core] perf probe: " tip-bot for Masami Hiramatsu
2014-06-06 7:13 ` [PATCH -tip 3/4] perf/probe: Improve an error message of perf probe --vars mode Masami Hiramatsu
2014-06-12 12:04 ` [tip:perf/core] perf probe: " tip-bot for Masami Hiramatsu
2014-06-06 7:14 ` [PATCH -tip 4/4] perf/probe: Improve error messages with --line option Masami Hiramatsu
2014-06-10 8:11 ` Namhyung Kim
2014-06-10 10:26 ` Masami Hiramatsu
2014-06-12 12:04 ` [tip:perf/core] perf probe: Improve error messages in " tip-bot for Masami Hiramatsu
2014-06-06 13:08 ` [PATCH -tip 0/4] perf/probe: Improve error messages Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140623031712.6541.39111.stgit@kbuild-fedora.novalocal \
--to=masami.hiramatsu.pt@hitachi.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=patrick@parcs.ath.cx \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®