From: Peter Zijlstra <peterz@infradead.org>
To: Davidlohr Bueso <davidlohr@hp.com>
Cc: Ingo Molnar <mingo@kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Aswin Chandramouleeswaran <aswin@hp.com>,
linux-kernel@vger.kernel.org, vgupta@synopsys.com
Subject: Re: [PATCH] arch,locking: Ciao arch_mutex_cpu_relax()
Date: Mon, 23 Jun 2014 08:54:23 +0200 [thread overview]
Message-ID: <20140623065423.GE19860@laptop.programming.kicks-ass.net> (raw)
In-Reply-To: <1403288473.10903.2.camel@buesod1.americas.hpqcorp.net>
On Fri, Jun 20, 2014 at 11:21:13AM -0700, Davidlohr Bueso wrote:
> diff --git a/arch/arc/include/asm/processor.h b/arch/arc/include/asm/processor.h
> index d99f9b3..8e1bf6b 100644
> --- a/arch/arc/include/asm/processor.h
> +++ b/arch/arc/include/asm/processor.h
> @@ -62,6 +62,8 @@ unsigned long thread_saved_pc(struct task_struct *t);
> #define cpu_relax() do { } while (0)
> #endif
>
> +#define arch_cpu_relax() cpu_relax()
> +
> #define copy_segments(tsk, mm) do { } while (0)
> #define release_segments(mm) do { } while (0)
I'm not at all sure that cpu_relax() definition ARC has is valid. We
rely on cpu_relax() being at least a barrier() all over the place, and
it doesn't need to be SMP only. You can have a UP wait loop waiting for
an interrupt for example.
Vineet?
next prev parent reply other threads:[~2014-06-23 6:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-20 18:21 Davidlohr Bueso
2014-06-23 6:54 ` Peter Zijlstra [this message]
2014-06-23 7:13 ` Vineet Gupta
2014-06-23 11:34 ` Peter Zijlstra
2014-06-23 6:58 ` Peter Zijlstra
2014-06-24 15:06 ` Davidlohr Bueso
2014-06-25 6:25 ` Heiko Carstens
2014-06-25 11:57 ` Linus Torvalds
2014-06-29 22:09 ` [PATCH v2] " Davidlohr Bueso
2014-08-05 13:04 ` Geert Uytterhoeven
2014-08-05 17:42 ` Davidlohr Bueso
2014-08-08 1:18 ` Davidlohr Bueso
2014-08-08 10:45 ` Guenter Roeck
2014-08-15 19:34 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140623065423.GE19860@laptop.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=aswin@hp.com \
--cc=davidlohr@hp.com \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=vgupta@synopsys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome