From: Greg KH <gregkh@linuxfoundation.org>
To: Tushar Behera <trblinux@gmail.com>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>,
Tushar Behera <tushar.b@samsung.com>,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH] usb: misc: usb3503: Update error code in print message
Date: Mon, 23 Jun 2014 12:18:21 -0400 [thread overview]
Message-ID: <20140623161821.GB20421@kroah.com> (raw)
In-Reply-To: <53A7C67F.3080409@gmail.com>
On Mon, Jun 23, 2014 at 11:47:35AM +0530, Tushar Behera wrote:
> On 06/17/2014 04:54 PM, Marek Szyprowski wrote:
> > Hello,
> >
> > On 2014-06-17 13:08, Tushar Behera wrote:
> >> 'err' is uninitialized, rather print the error code directly.
> >>
> >> This also fixes following warning.
> >> drivers/usb/misc/usb3503.c: In function ‘usb3503_probe’:
> >> drivers/usb/misc/usb3503.c:195:11: warning: ‘err’ may be used
> >> uninitialized
> >> in this function [-Wmaybe-uninitialized]
> >> dev_err(dev, "unable to request refclk (%d)\n", err);
> >>
> >> Signed-off-by: Tushar Behera <tushar.b@samsung.com>
> >
> > Acked-by: Marek Szyprowski <m.szyprowski@samsung.com>
> >
>
> Greg,
>
> Would you please pick up this patch?
Give me a chance, it's in my todo queue...
prev parent reply other threads:[~2014-06-23 16:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-17 11:08 Tushar Behera
2014-06-17 11:24 ` Marek Szyprowski
2014-06-23 6:17 ` Tushar Behera
2014-06-23 16:18 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140623161821.GB20421@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=trblinux@gmail.com \
--cc=tushar.b@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®