From: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
To: Lee Jones <lee.jones@linaro.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Alan, can you revisit a patch you authored please?
Date: Tue, 24 Jun 2014 13:36:11 +0100 [thread overview]
Message-ID: <20140624133611.62e4c3b7@alan.etchedpixels.co.uk> (raw)
In-Reply-To: <20140623085345.GD8847@lee--X1>
On Mon, 23 Jun 2014 09:53:45 +0100
Lee Jones <lee.jones@linaro.org> wrote:
> Hi Alan,
>
> I'm looking at a patch you wrote which can be foudn below at [1]. Are
> you sure it's correct to ignore i.e not return -ENOMEM from
> platform_device_add_data() in pcf50633_probe()? I believe if
> platform_device_add_data() returns an error we should
> platform_device_put() and return immediately. Can you tell me if you
> agree. If you don't, would you mind explaining to me why please?
I made the change to maximise the chance of things booting up ok, but I
agree, its a pointless exercise. If we fail to add the data we should
just chuck it.
Alan
next prev parent reply other threads:[~2014-06-24 12:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-23 8:53 Lee Jones
2014-06-24 12:36 ` One Thousand Gnomes [this message]
2014-06-24 14:19 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140624133611.62e4c3b7@alan.etchedpixels.co.uk \
--to=gnomes@lxorguk.ukuu.org.uk \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®