mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: shirishpargaonkar@gmail.com
Cc: linux-kernel@vger.kernel.org, vgoyal@redhat.com,
	Shirish Pargaonkar <spargaonkar@suse.com>
Subject: Re: [PATCH] blkio: Release blkg infrastructure only after last policy is deactivated.
Date: Tue, 24 Jun 2014 17:09:30 -0400	[thread overview]
Message-ID: <20140624210930.GD14909@htj.dyndns.org> (raw)
In-Reply-To: <1403549545-6535-1-git-send-email-spargaonkar@suse.com>

Hello,

On Mon, Jun 23, 2014 at 01:52:25PM -0500, shirishpargaonkar@gmail.com wrote:
> From: Shirish Pargaonkar <spargaonkar@suse.com>
> 
> Release blkg infrastructure only after last policy is deactivated
> (i.e. let blkg_destroy_all() be called only from blkcg_deactivate_policy())
> 
> Otherwise, module can oops because root_blkg gets assigned NULL during
> cleanup and we attempt draining the service queues via root_blkg afterwords.

I'm not sure this fix makes sense.  Cleanup path oopses on an already
freed resource.  How can the solution be not freeing?  Why not simply
make blkcg_drain_queue() bail if the blkgs are all destroyed?  The
whole thing is fully synchronized with the queuelock, right?

Can you please also cc Jens when you post the next iteration?

Thanks.

-- 
tejun

  parent reply	other threads:[~2014-06-24 21:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-23 18:52 shirishpargaonkar
2014-06-23 18:56 ` Shirish Pargaonkar
2014-06-24 21:09 ` Tejun Heo [this message]
2014-06-24 21:37   ` Shirish Pargaonkar
2014-06-24 21:43     ` Tejun Heo
2014-07-04 17:18       ` Tejun Heo
2014-07-04 18:54         ` Shirish Pargaonkar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140624210930.GD14909@htj.dyndns.org \
    --to=tj@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shirishpargaonkar@gmail.com \
    --cc=spargaonkar@suse.com \
    --cc=vgoyal@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®