From: Jean Delvare <jdelvare@suse.de>
To: "Julien D'Ascenzio" <jdascenzio@yahoo.fr>
Cc: Guenter Roeck <linux@roeck-us.net>,
lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hwmon: (gpio-fan) Change name used in hwmon_device_register_with_groups
Date: Thu, 26 Jun 2014 00:02:55 +0200 [thread overview]
Message-ID: <20140626000255.1a5e2770@endymion.delvare> (raw)
In-Reply-To: <1403726431-18749-1-git-send-email-jdascenzio@yahoo.fr>
On Wed, 25 Jun 2014 22:00:31 +0200, Julien D'Ascenzio wrote:
> Since commit 648cd48c9e566f53c5df30d79857e0937ae13b09
> The hwmon name attributes must not include '-' so the name must be
> rename from gpio-fan to gpio_fan
>
> Signed-off-by: Julien D'Ascenzio <jdascenzio@yahoo.fr>
> ---
> drivers/hwmon/gpio-fan.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/gpio-fan.c b/drivers/hwmon/gpio-fan.c
> index 73181be..160ca00 100644
> --- a/drivers/hwmon/gpio-fan.c
> +++ b/drivers/hwmon/gpio-fan.c
> @@ -538,7 +538,7 @@ static int gpio_fan_probe(struct platform_device *pdev)
>
> /* Make this driver part of hwmon class. */
> fan_data->hwmon_dev = hwmon_device_register_with_groups(&pdev->dev,
> - "gpio-fan", fan_data,
> + "gpio_fan", fan_data,
> gpio_fan_groups);
> if (IS_ERR(fan_data->hwmon_dev))
> return PTR_ERR(fan_data->hwmon_dev);
Reviewed-by: Jean Delvare <jdelvare@suse.de>
--
Jean Delvare
SUSE L3 Support
prev parent reply other threads:[~2014-06-25 22:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1403726431-18749-1-git-send-email-jdascenzio@yahoo.fr>
2014-06-25 20:47 ` Guenter Roeck
2014-06-25 22:02 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140626000255.1a5e2770@endymion.delvare \
--to=jdelvare@suse.de \
--cc=jdascenzio@yahoo.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lm-sensors@lm-sensors.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®