From: Steven Rostedt <rostedt@goodmis.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Subbaraman Narayanamurthy <subbaram@codeaurora.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kthread: Fix the race condition when kthread is parked
Date: Wed, 25 Jun 2014 22:03:16 -0400 [thread overview]
Message-ID: <20140626020316.GB25209@home.goodmis.org> (raw)
In-Reply-To: <20140626020022.GA25209@home.goodmis.org>
On Wed, Jun 25, 2014 at 10:00:22PM -0400, Steven Rostedt wrote:
> On Thu, Jun 26, 2014 at 02:43:56AM +0200, Thomas Gleixner wrote:
> >
> > Subject: kthread: Plug park/ unplug race
> > From: Thomas Gleixner <tglx@linutronix.de>
> > Date: Thu, 26 Jun 2014 01:24:36 +0200
> >
> > The kthread park/unpark logic has the following issue:
> >
> > Task CPU 0 CPU 1
> >
> > T1 unplug cpu1
> > kthread_park(T2)
> > set_bit(KTHREAD_SHOULD_PARK);
> > wait_for_completion()
> > T2 parkme(X)
>
> But with your patch, isn't it possible for T1 to call thread_unpark here?
Let me answer that.... No, it can't.
I missed the wait_for_completion() above, which will prevent this from happening.
Nevermind, I'll go work on something less brain intensive.
-- Steve
>
> Then looking at the code I see this turn of events:
>
> if (test_bit(KTHREAD_IS_PER_CPU, &kthread->flags))
> __kthread_bind(k, kthread->cpu, TASK_PARKED);
>
> Which in __kthread_bind() (state == TASK_PARKED)
>
> if (!wait_task_inactive(p, state)) {
> WARN_ON(1);
> return;
> }
>
> Where wait_task_inactive() does:
>
> while (task_running(rq, p)) {
> if (match_state && unlikely(p->state != match_state))
> return 0;
>
> As match_state is non zero and p->state != match_state because it hasn't been
> set yet. The wait_task_inactive() returns zero, and then we hit the WARN_ON()
> in __kthread_bind().
>
> -- Steve
next prev parent reply other threads:[~2014-06-26 2:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-25 19:42 Subbaraman Narayanamurthy
2014-06-26 0:43 ` Thomas Gleixner
2014-06-26 2:00 ` Steven Rostedt
2014-06-26 2:03 ` Steven Rostedt [this message]
2014-06-26 21:31 ` Subbaraman Narayanamurthy
2014-06-26 23:50 ` Thomas Gleixner
2014-11-02 12:01 Daniel J Blueman
2014-11-03 19:44 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140626020316.GB25209@home.goodmis.org \
--to=rostedt@goodmis.org \
--cc=linux-kernel@vger.kernel.org \
--cc=subbaram@codeaurora.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®