From: Steven Rostedt <rostedt@goodmis.org>
To: Fabian Frederick <fabf@skynet.be>
Cc: linux-kernel@vger.kernel.org, Frederic Weisbecker <fweisbec@gmail.com>
Subject: Re: [PATCH 1/1] kernel/trace/trace.c: remove unnecessary null test before debugfs_remove
Date: Thu, 26 Jun 2014 13:44:35 -0400 [thread overview]
Message-ID: <20140626134435.2cb2e047@gandalf.local.home> (raw)
In-Reply-To: <1403802871-8599-1-git-send-email-fabf@skynet.be>
On Thu, 26 Jun 2014 19:14:31 +0200
Fabian Frederick <fabf@skynet.be> wrote:
> This fixes checkpatch warning:
>
> "WARNING: debugfs_remove(NULL) is safe this check is probably not required"
Thanks, applied to my 3.17 queue.
-- Steve
>
> Cc: Steven Rostedt <rostedt@goodmis.org>
> Cc: Frederic Weisbecker <fweisbec@gmail.com>
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
> ---
> kernel/trace/trace.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
> index 384ede3..58c78e4 100644
> --- a/kernel/trace/trace.c
> +++ b/kernel/trace/trace.c
> @@ -6095,10 +6095,8 @@ destroy_trace_option_files(struct trace_option_dentry *topts)
> if (!topts)
> return;
>
> - for (cnt = 0; topts[cnt].opt; cnt++) {
> - if (topts[cnt].entry)
> - debugfs_remove(topts[cnt].entry);
> - }
> + for (cnt = 0; topts[cnt].opt; cnt++)
> + debugfs_remove(topts[cnt].entry);
>
> kfree(topts);
> }
prev parent reply other threads:[~2014-06-26 17:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-26 17:14 Fabian Frederick
2014-06-26 17:44 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140626134435.2cb2e047@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=fabf@skynet.be \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®