From: Andrew Morton <akpm@linux-foundation.org>
To: "Luis R. Rodriguez" <mcgrof@suse.com>
Cc: "Luis R. Rodriguez" <mcgrof@do-not-panic.com>,
gregkh@linuxfoundation.org, hpa@linux.intel.com,
linux-kernel@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
Stephen Warren <swarren@wwwdotorg.org>,
Michal Hocko <mhocko@suse.cz>, Petr Mladek <pmladek@suse.cz>,
Joe Perches <joe@perches.com>, Arun KS <arunks.linux@gmail.com>,
Kees Cook <keescook@chromium.org>,
Davidlohr Bueso <davidlohr@hp.com>,
Chris Metcalf <cmetcalf@tilera.com>
Subject: Re: [PATCH v8 4/4] printk: allow increasing the ring buffer depending on the number of CPUs
Date: Thu, 26 Jun 2014 16:20:14 -0700 [thread overview]
Message-ID: <20140626162014.156f6741c7d9d3234879054f@linux-foundation.org> (raw)
In-Reply-To: <20140626231630.GI27687@wotan.suse.de>
On Fri, 27 Jun 2014 01:16:30 +0200 "Luis R. Rodriguez" <mcgrof@suse.com> wrote:
> > > Another note -- since this option depends on SMP and !BASE_SMALL technically
> > > num_possible_cpus() won't ever return something smaller than or equal to 1
> > > but because of the default values chosen the -1 on the compuation does affect
> > > whether or not this will trigger on > 64 CPUs or >= 64 CPUs, keeping the
> > > -1 means we require > 64 CPUs.
> >
> > hm, that sounds like more complexity.
> >
> > > This all can be changed however we like but the language and explained logic
> > > would just need to be changed.
> >
> > Let's start out simple. What's wrong with doing
> >
> > log buf len = max(__LOG_BUF_LEN, nr_possible_cpus * per-cpu log buf len)
>
> Sure, you already took in the patch series though so how would you like to
> handle a respin, you just drop the last patch and we respin it?
A fresh patch would suit. That's if you think it is a reasonable
approach - you've thought about this stuff more than I have!
next prev parent reply other threads:[~2014-06-26 23:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-18 20:45 [PATCH v8 1/4] printk: make dynamic kernel ring buffer alignment explicit Luis R. Rodriguez
2014-06-18 20:45 ` [PATCH v8 2/4] printk: move power of 2 practice of ring buffer size to a helper Luis R. Rodriguez
2014-06-18 20:45 ` [PATCH v8 3/4] printk: make dynamic units clear for the kernel ring buffer Luis R. Rodriguez
2014-06-18 20:45 ` [PATCH v8 4/4] printk: allow increasing the ring buffer depending on the number of CPUs Luis R. Rodriguez
2014-06-23 22:41 ` Andrew Morton
2014-06-24 0:20 ` Luis R. Rodriguez
2014-06-24 0:45 ` Andrew Morton
2014-06-24 1:05 ` Luis R. Rodriguez
2014-06-26 21:41 ` Andrew Morton
2014-06-26 23:16 ` Luis R. Rodriguez
2014-06-26 23:20 ` Andrew Morton [this message]
2014-06-26 23:32 ` Luis R. Rodriguez
2014-06-27 23:59 ` Andrew Morton
2014-06-28 1:20 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140626162014.156f6741c7d9d3234879054f@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=andrew@lunn.ch \
--cc=arunks.linux@gmail.com \
--cc=cmetcalf@tilera.com \
--cc=davidlohr@hp.com \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@linux.intel.com \
--cc=joe@perches.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@do-not-panic.com \
--cc=mcgrof@suse.com \
--cc=mhocko@suse.cz \
--cc=pmladek@suse.cz \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®