Re: [PATCH] tools: selftests - create a separate hotplug target

[Andrew Morton <akpm@linux-foundation.org>]

On Fri, 27 Jun 2014 13:59:55 -0600 Shuah Khan <shuah.kh@samsung.com> wrote:

> > I don't know really.  You know more about this than I - what advantages
> > does the separate-make-target approach have over this approach?
> >
> 
> Currently these tests run with full range - i.e try to offline
> all cpus that are hotpluggable and try to offline all memory
> that is hotpluggable. This results in hangs.
> 
> Creating a separate target the way I did it in this patch excludes these
> tests all together. i.e when somebody runs:
> 
> make -C tools/testing/selftests run_tests
> 
> hotplug tests don't run.
> 
> Instead, with a few changes, tests can be run with a reduced scope so
> a % of the memory gets offlined as opposed to all of it and the same
> thing with cpus. This way hotplug code gets tested as opposed to
> being excluded in a default test run case.
> 
> However, if limited scope testing isn't useful, separate target is
> better until tests can be made safe to run without hangs.

hm, OK.  So it sounds like the best solution would be to run the
limited tests by default and to require special intervention to run the
full tests.

I guess a separate make target is a suitable way of running the full
tests.  We could use an environment variable or various other things.