From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754091AbaF0P5u (ORCPT ); Fri, 27 Jun 2014 11:57:50 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:38529 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753451AbaF0P5s (ORCPT ); Fri, 27 Jun 2014 11:57:48 -0400 Date: Fri, 27 Jun 2014 10:57:13 -0500 From: Felipe Balbi To: Rickard Strandqvist CC: Felipe Balbi , Tony Lindgren , Russell King , , , , , Roger Quadros Subject: Re: [PATCH] arch: arm: mach-omap2: usb-tusb6010.c: Cleaning up variable is set more than once Message-ID: <20140627155713.GM8069@saruman.home> Reply-To: References: <1403699310-22960-1-git-send-email-rickard_strandqvist@spectrumdigital.se> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="cGfB/trNgB3WtPHu" Content-Disposition: inline In-Reply-To: <1403699310-22960-1-git-send-email-rickard_strandqvist@spectrumdigital.se> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --cGfB/trNgB3WtPHu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jun 25, 2014 at 02:28:30PM +0200, Rickard Strandqvist wrote: > A struct member variable is set to the same value more than once >=20 > This was found using a static code analysis program called cppcheck. >=20 > Signed-off-by: Rickard Strandqvist I think there was a bigger series from Roger rewriting most of this, but if I'm mistaken: Acked-by: Felipe Balbi > --- > arch/arm/mach-omap2/usb-tusb6010.c | 1 - > 1 file changed, 1 deletion(-) >=20 > diff --git a/arch/arm/mach-omap2/usb-tusb6010.c b/arch/arm/mach-omap2/usb= -tusb6010.c > index e832bc7..8333400 100644 > --- a/arch/arm/mach-omap2/usb-tusb6010.c > +++ b/arch/arm/mach-omap2/usb-tusb6010.c > @@ -95,7 +95,6 @@ static int tusb_set_sync_mode(unsigned sysclk_ps) > dev_t.t_avdp_w =3D t_scsnh_advnh; > dev_t.cyc_aavdh_we =3D 3; > dev_t.cyc_wpl =3D 6; > - dev_t.t_ce_rdyz =3D 7000; > =20 > gpmc_calc_timings(&t, &tusb_sync, &dev_t); > =20 > --=20 > 1.7.10.4 >=20 --=20 balbi --cGfB/trNgB3WtPHu Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJTrZRZAAoJEIaOsuA1yqREtuwQAJOHyvyVnUtDT20I+RGkVhI9 K15ifWzoQ7eh0ZfeksLgvy3ilmNyt/q2IxiIhZ2UJXHkemD69EYDEWf/kLRlFlmO sEzMrGPNI1uOVtmMgd/RdGTU+fvrv8a7gb63JkVGSLTjZnA2CDalKon7eQNpIFhc cy/jQzG1B/nOnuvDCxfLxMcKQWkTIB46w2yWylU+0zr6ch0/9pviRpzuHB3jXM0m GF6VM6DnqQwSp/YBrOBhvA26AUdVqGXdN5F2e3vRdOhHJaAOJ30lG+ZiOgeifKvH tUTX3rKJzVvbVaYOvwSFjD5Dh3cZxJrLG13PzDeWLcJLol1CGySQoXwkaOAR2c5X LwHyuSE33oUJgajM7ik20RPYj7sbaM9yuS0AT2+BqoFirPq/G8fxD4KWSeCEenP+ 92/nDxEApRGLZKtNvwC77FXxyp3C5Z0TOAviZTD4pqiFiEN6qlwiAVunuKmWTBS7 IrPHmc+Db0FPHWq58Q7HfQ1FCNsmO2+PFbfgCHnyJXiHfoAz4T9URA30REk5MgAi 3oNcRAbdLMdTz+nfKvvNsb9/wssTG78tdzfdSdrDlY4mkaKvnURfnUYSSEtI/w2x Gagu+O7D+/sZZZFvA2pOOtTHBv5MLUnQork5D6icsm9kKnjp+/l+UAJYjPsOc/mD vktCFVAYxAtUq2vysTN4 =U2sB -----END PGP SIGNATURE----- --cGfB/trNgB3WtPHu--