Re: [PATCH] trace-cmd: handle NULL comm name in .dat file

[Steven Rostedt <rostedt@goodmis.org>]

On Thu, 26 Jun 2014 09:22:12 -0700
Josef Bacik <jbacik@fb.com> wrote:

> Sometimes the comm field in the trace.dat file can be empty which means that the
> event parsing stuff can pass a NULL into pevent_register_comm.  To fix this just
> check if we are NULL and generate a bogus comm name for that PID.  This keeps us
> from segfaulting.  Thanks,
> 
> Signed-off-by: Josef Bacik <jbacik@fb.com>

Applied, thanks!

-- Steve

> ---
>  event-parse.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/event-parse.c b/event-parse.c
> index 18b3587..00304fe 100644
> --- a/event-parse.c
> +++ b/event-parse.c
> @@ -303,7 +303,10 @@ int pevent_register_comm(struct pevent *pevent, const char *comm, int pid)
>  	if (!item)
>  		return -1;
>  
> -	item->comm = strdup(comm);
> +	if (comm)
> +		item->comm = strdup(comm);
> +	else
> +		item->comm = strdup("<...>");
>  	if (!item->comm) {
>  		free(item);
>  		return -1;