From: Greg KH <gregkh@linuxfoundation.org>
To: Guillaume Morin <guillaume@morinfr.org>
Cc: jic23@kernel.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org, mwelling@ieee.org
Subject: Re: [PATCH v3 1/1] staging: iio: ad9850.c: code cleanup
Date: Sat, 28 Jun 2014 11:30:27 -0400 [thread overview]
Message-ID: <20140628153027.GF29548@kroah.com> (raw)
In-Reply-To: <936f1ac494ee8708e37a8cb16a70aa3f007e93cd.1403965958.git.guillaume@morinfr.org>
On Sat, Jun 28, 2014 at 05:13:19PM +0200, Guillaume Morin wrote:
> checkpath.pl was complaining about value_mask:
> ERROR: Macros with complex values should be enclosed in parenthesis
>
> I fixed this by simply removing it since it's not used (as well as another macro).
> Got rid of the un-necessary error_ret label as well. Both changes were suggested
> by Michael Welling.
Very good. But (you knew there was a but, right?)
When giving credit to someone else like this, you can just do it with a
simple:
Reported-by: Michael Welling <mwelling@ieee.org>
in the signed-off-by area, no need to write a sentance about it.
Care to try a 4th time here?
thanks,
greg k-h
prev parent reply other threads:[~2014-06-28 15:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-28 15:13 Guillaume Morin
2014-06-28 15:30 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140628153027.GF29548@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=guillaume@morinfr.org \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mwelling@ieee.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome