From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Nicholas Krause <xerofoify@gmail.com>
Cc: ulli.kroll@googlemail.com, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fixes gemmi_idle in file idle.c
Date: Mon, 30 Jun 2014 10:41:57 +0100 [thread overview]
Message-ID: <20140630094157.GT32514@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1404096760-5239-1-git-send-email-xerofoify@gmail.com>
On Sun, Jun 29, 2014 at 10:52:40PM -0400, Nicholas Krause wrote:
> disables the IRQ line in gemmi_idle before calling cpu_do_idle.
> In addition, according to the Fixme message in this file fixes
> races that may occur due to not disabling the IRQ before calling
> cpu_do_idle.
1) the idle method is called with interrupts already disabled.
2) I wonder if you read the comment above the comment you removed, and
if so, why it wasn't removed.
3) can you indicate how the hardware problem has been fixed, or give some
justification why this change should be accepted.
--
FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly
improving, and getting towards what was expected from it.
next prev parent reply other threads:[~2014-06-30 9:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-30 2:52 Nicholas Krause
2014-06-30 6:43 ` Arnd Bergmann
2014-06-30 9:41 ` Russell King - ARM Linux [this message]
2014-07-01 1:59 ` Nick Krause
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140630094157.GT32514@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ulli.kroll@googlemail.com \
--cc=xerofoify@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®