mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Don A. Bailey" <donb@securitymouse.com>
Cc: Richard Weinberger <richard@nod.at>,
	Markus Oberhumer <markus@oberhumer.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: lzo1x_decompress_safe: Macro compares unsigned to 0 (NO_EFFECT)
Date: Mon, 30 Jun 2014 09:23:54 -0700	[thread overview]
Message-ID: <20140630162354.GB24179@kroah.com> (raw)
In-Reply-To: <CAFkuX4uoMFC1jT4Oeqj3HzfPWG3JFiEnysODEopfL8aQod4_mQ@mail.gmail.com>

On Mon, Jun 30, 2014 at 09:34:44AM -0600, Don A. Bailey wrote:
> In the case of macro instances that include a '0', the overflow test is
> purposefully benign. We don't need a test for these cases. It was easy to throw
> a '0' in there to accommodate for the new two-param call. But, to appease
> Coverity, a second single-param macro that doesn't check for overflow could be
> created. 

Not needed, we don't need to "apease" coverity :)

Let's just leave this as-is.

thanks,

greg k-h

      parent reply	other threads:[~2014-06-30 16:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <53b0f0f715b96_146f12c1338333fa@209.249.196.67.mail>
2014-06-30  7:22 ` Richard Weinberger
2014-06-30 14:37   ` Greg Kroah-Hartman
     [not found]     ` <CAFkuX4uoMFC1jT4Oeqj3HzfPWG3JFiEnysODEopfL8aQod4_mQ@mail.gmail.com>
2014-06-30 16:23       ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140630162354.GB24179@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=donb@securitymouse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=markus@oberhumer.com \
    --cc=richard@nod.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®