Re: [PATCH 3/3] perf tools: Add ui.show-headers config file option

[Jiri Olsa <jolsa@redhat.com>]

On Mon, Jun 30, 2014 at 08:13:24PM +0900, Namhyung Kim wrote:
> Hi Jiri,
> 
> 2014-06-27 (금), 18:26 +0200, Jiri Olsa:
> > Adding report.show-headers config file option to setup
> > the appearance of the columns headers.
> > 
> > Currently columns headers are displayed by default, following
> > lines in ~/.perfconfig file will disable that:
> > 
> >   [ui]
> >         show-headers = true
> 
> s/true/false/  :)

ouch ;-)

> 
> I'm afraid that we might need to add some code to show/hide column
> headers for stdio and GTK too..
> 
> 
> > 
> > Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
> > Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
> > Cc: David Ahern <dsahern@gmail.com>
> > Cc: Frederic Weisbecker <fweisbec@gmail.com>
> > Cc: Ingo Molnar <mingo@kernel.org>
> > Cc: Paul Mackerras <paulus@samba.org>
> > Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
> > Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> 
> Anyway, with above typo fixed, patches look good!
> 
> Acked-by: Namhyung Kim <namhyung@kernel.org>

thanks,
jirka