From: Tejun Heo <tj@kernel.org>
To: Filipe Brandenburger <filbranden@google.com>
Cc: Christoph Lameter <cl@linux-foundation.org>,
Eric Dumazet <eric.dumazet@gmail.com>,
"H. Peter Anvin" <hpa@linux.intel.com>,
Andi Kleen <andi@firstfloor.org>, Zhengyu He <hzy@google.com>,
Greg Thelen <gthelen@google.com>,
linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] core: fix typo in percpu read_mostly section
Date: Tue, 1 Jul 2014 16:46:17 -0400 [thread overview]
Message-ID: <20140701204617.GC12459@htj.dyndns.org> (raw)
In-Reply-To: <1404241907-27093-1-git-send-email-filbranden@google.com>
On Tue, Jul 01, 2014 at 12:11:47PM -0700, Filipe Brandenburger wrote:
> From: Zhengyu He <hzy@google.com>
>
> This fixes a typo that named the read_mostly section of percpu as
> readmostly. It works fine with SMP because the linker script specifies
> .data..percpu..readmostly. However, UP kernel builds don't have percpu
> sections defined and the non-percpu version of the section is called
> data..read_mostly, so .data..readmostly will float around and may break
> things unexpectedly.
>
> Looking at the original change that introduced data..percpu..readmostly
> (commit c957ef2c59e952803766ddc22e89981ab534606f), it looks like this
> was the original intention.
>
> Tested: Built UP kernel and confirmed the sections got merged.
>
> - Before the patch:
> $ objdump -h vmlinux.o | grep '\.data\.\.read.*mostly'
> 38 .data..read_mostly 00004418 0000000000000000 0000000000000000 00431ac0 2**6
> 50 .data..readmostly 00000014 0000000000000000 0000000000000000 00444000 2**3
>
> - After the patch:
> $ objdump -h vmlinux.o | grep '\.data\.\.read.*mostly'
> 38 .data..read_mostly 00004438 0000000000000000 0000000000000000 00431ac0 2**6
>
> Signed-off-by: Zhengyu He <hzy@google.com>
> Signed-off-by: Filipe Brandenburger <filbranden@google.com>
Applied to percpu/for-3.16-fixes.
Thanks.
--
tejun
prev parent reply other threads:[~2014-07-01 20:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-23 18:16 Filipe Brandenburger
2014-07-01 19:11 ` Filipe Brandenburger
2014-07-01 20:46 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140701204617.GC12459@htj.dyndns.org \
--to=tj@kernel.org \
--cc=andi@firstfloor.org \
--cc=cl@linux-foundation.org \
--cc=eric.dumazet@gmail.com \
--cc=filbranden@google.com \
--cc=gthelen@google.com \
--cc=hpa@linux.intel.com \
--cc=hzy@google.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®